-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible approach on icons #376
Comments
Yes I like your suggestion! Maybe we can remove the Icon-styles at all, that would be awesome i guess. Then every icon-system can be included as you said. Currently I am busy but I look what I can do, or if someone wants to contribute I would highly appreciate it. Thanks. |
Before submitting...
Context
There are a lot of options when it comes to icons. Google alone provides more than one set. Therefore, I think the approach of MaterializeCSS may need some changes.
Current Behavior
Currently the docs require this pattern for icons:
<i class="material-icons">add</i>
Also CSS styles explicitly use selectors like these:
If I use
<span>
instead of<i>
, the output sometimes becomes broken. Also now we have Material Symbols. Some people may even want to use icons from a different source. I think it would be very good if the framework did not dictate which icons to use.Expected behavior
No response
Possible Solutions or Causes
Perhaps there could be a specific class or data attribute that must be added to any icon element? Then in CSS we would not need to list various tags and classes and it would be enough to have something like
[data-icon] {}
or.materialize-icon {}
Your Environment
The text was updated successfully, but these errors were encountered: