Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_constants.scss is missing from mdc-theme.import.scss #8053

Open
hilljh82 opened this issue Mar 17, 2023 · 1 comment
Open

_constants.scss is missing from mdc-theme.import.scss #8053

hilljh82 opened this issue Mar 17, 2023 · 1 comment
Labels

Comments

@hilljh82
Copy link
Contributor

Bug report

In ember-cli-mdc, we import the style to generate the default styles of the ember application. We use the following import statement in the ember-cli-mdc-theme addon:

@use "app-theme";
@use "@material/theme/mdc-theme";

This ensure all add-ons and the application have the default application styles set by the developer. This used to work under 6.0.0. We are upgrading to 14.0.0, and the are getting the following error:

Can't find stylesheet to import.
  ╷
3 │ @forward "constants" as mdc-theme-*;
  │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  node_modules/@material/theme/mdc-theme.import.scss 3:1  
@import addon/styles/addon.scss 2:9                             root stylesheet

This is happening because _constants.scss is no longer present in the repo. If either add that file, or remove the line in question from mdc-theme.import.scss, then stylesheet will compile.

Steps to reproduce

Include the scss file as follows:

@use "@material/theme/mdc-theme";

Actual behavior

Give the error outlined above.

Expected behavior

The scss file should compile.

Screenshots

N/A

Your Environment:

Software Version(s)
MDC Web 14.0.0
Browser All
Operating System MacOS X

Additional context

This is preventing us from updating ember-cli-mdc.

Possible solution

Remove the line in question from mdc-theme.import.scss.

@hilljh82 hilljh82 added the bug label Mar 17, 2023
@sz-FarmersEdge
Copy link

Do we have a fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants