-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blas axpy
test is not meaningful
#255
Comments
Note this might have been at least partly obscured by TypeScript itself. Changing the dynamic |
Good catch! It's a result of having the nblas module optional. When I implemented the try..catch-require, it made typescript typing impossible because the nblas types (https://github.com/nperf/nblas/blob/master/src/types.ts) are not there because the package is not installed. Maybe there is a modern solution for this? |
The
axpy
test checks that the return value ofaxpy
is the same as the return value ofnblas.daxpy
. These functions actually have return typevoid
so the check is just thatundefined === undefined
!The actual thing
saxpy
/daxpy
should do is mutatey
in place.vectorious/src/blas.spec.ts
Line 17 in 3ec2561
The text was updated successfully, but these errors were encountered: