-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link of logo not pointing to basepath #551
Comments
This theme currently isn't really actively maintained. Meanwhile you could use my fork where this and a lot of other bugs are fixed. |
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this issue
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this issue
Jan 23, 2024
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this issue
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
Whenever the web pages are not deployed in the root but under a subpath you cannot use the click on the logo as the link points to the urls root and not the basepath of your website.
Presumed cause:
In .../layouts/partials/logo.html
<a id="logo" href='{{ (cond (and (ne .Site.Params.landingPageURL nil) (.Site.IsMultiLingual)) .Site.Params.landingPageURL "/") }}'>
no
relLangURL
so href does not carry theBasePath
.Proposed modification:
add relLangURL
<a id="logo" href='{{ (cond (and (ne .Site.Params.landingPageURL nil) (.Site.IsMultiLingual)) .Site.Params.landingPageURL "/") | relLangURL }}'>
System-Info:
vanilla deployed on github-pages
The text was updated successfully, but these errors were encountered: