-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues with a long line #270
Comments
@joyofscripting The previous versions in which everything was fine, is it below 3? Since the breaking change occurred in version 3, in which there was a switch from ace to codemiror and texmate grammars |
@antonreshetov Yes, this might be true. I remember that it worked back in July and as far as I know version 3 saw the world at the beginning of August, |
I originally thought it might be related to onigasm and it seems to be right. I found this issue zikaari/onigasm#6. Unfortunately the issue is not resolved. I also tried replacing the Original grammar - https://raw.githubusercontent.com/microsoft/vscode/main/extensions/sql/syntaxes/sql.tmLanguage.json New grammar- https://github.com/textmate/sql.tmbundle/blob/master/Syntaxes/SQL.plist Edit |
Describe the bug
I discovered that my beloved installation of massCode gets a bit unresponsive and takes a longer time for searches when I add SQL snippets that contain long lists of comma-separated numbers in the WHERE-condition.
Normally massCode is very responsive. you can click anywhere and the UI will react immediately. Also searches are normally very fast, a real joy. But when you add a snippet of the mentioned type, massCode's UI will become less responsive, searches will take some time and while the search is performed, the UI is almost blocked.
Currently I have 216 snippets organized in massCode, mostly short SQL statements, Python and Swift code.
Of couse one could argue that a snippet with a list of 1000 comma-separated values is not really a snippet anymore. And I can absolutely understand this perspective. But it was working perfectly in previous versions. So it might be just some kind of bug.
To reproduce
In my case the UI gets unresponsive after step 5 and the search takes some time (10 seconds). Once you fully deleted the created 'SQLTEST' snippet, everything works as before, the UI is responsive, the searches quick again.
list_of_1000_numbers.txt
Version
3.4.1
OS
Windows 10
Validations
The text was updated successfully, but these errors were encountered: