[SOLVED] Regressions of new version of "vergilius" style #502
-
|
Certain time ago, after some (pretty recent) commits, the article viewer obtained fresh While I don't mind such beautification, it introduced a lots of bugs to me, for example with tables, with articles which are having some bits of their own styling, and I was once again left being unable to change the font size there, too (which could be adjusted under "Article browser font" in Settings). It was introduced with 63865ec and 6e10be3 I understand. Myself, I have simply copied the previous version of "vergilius" (0.24), and keep using it as it looks and works much better in most cases. My suggestion, however, is that to return that previous version of "vergilius" back with the name of "vergilius-old", or something, and keep it as a separate theme, unless it will be too bothersome to maintain so many styles. |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 15 replies
-
|
I see. I did some testing with the style and it worked. I agree that CSS style is rather problematic part of the app, because contents of articles are very diverse and often (semi)-broken. I will revert |
Beta Was this translation helpful? Give feedback.
-
But if you mean creating my own, it is rather problematic for me, because as I try to review that 46kb, 46000+ characters long, file, it sends my CPU fly quite easily, say nothing of it being a one-liner (the Could there be added some bare Or most of that required for it to work properly? |
Beta Was this translation helpful? Give feedback.
-
|
:D Sure, I will create new skin and make it easier to open in dumb text editors. For example Visual Studio Code opens those files with long one-liners just fine, btw. Basically, you can remove the huge <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html>
<html lang="en">
<head>
<style>
</style>
<style>
html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, img, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td,
article, aside, canvas, details, embed,
figure, figcaption, footer, header, hgroup,
menu, nav, output, ruby, section, summary,
time, mark, audio, video {
font-size: 100%;
font: inherit;
}
</style>
<style>
html {
height: 100%;
}
body {
height: 100%;
}
</style>
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- PERCENTAGE-1 gets replaced by actual title of the message by RSS Guard. -->
<title>%1</title>
</head>
<body>
%2
</body>
</html>You need to pay special attention to <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html>
<html lang="en">
<head>
<style>
</style>
<style>
html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, img, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td,
article, aside, canvas, details, embed,
figure, figcaption, footer, header, hgroup,
menu, nav, output, ruby, section, summary,
time, mark, audio, video {
font-size: 100%;
font: inherit;
}
</style>
<style>
html {
height: 100%;
}
body {
height: 100%;
}
</style>
<meta name="viewport" content="width=device-width, initial-scale=1">
<!-- PERCENTAGE-1 gets replaced by actual title of the message by RSS Guard. -->
<title>SOME TITLE</title>
</head>
<body>
<div class="card filled fluid" dir="auto">
<h5 class="doc section">SOME TITLE <a class="button small primary" href="%3">🔗URL</a> %6</h5>
<div class="doc section">
<div style="text-align: center;">
%2, %5
</div>
<div style="padding: 2px; margin: 0px;">
%7
</div>
%4
</div>
</div>
</body>
</html> |
Beta Was this translation helpful? Give feedback.
-
I lose nothing of importance by doing it? There are no such places:
Or similar? |
Beta Was this translation helpful? Give feedback.
-
That won't work, you know. |
Beta Was this translation helpful? Give feedback.
-
Ha! the problem is actually that it is a one-liner. Kate can't properly handle lines of 10000+ characters. The message as follows:——
I can temporary raise the limit, of course. |
Beta Was this translation helpful? Give feedback.
-
I lose nothing of importance by doing it? There are no such places:
Or similar? |
Beta Was this translation helpful? Give feedback.
-
|
Wait, will write up "empty" skin, you can work with with commentary. |
Beta Was this translation helpful? Give feedback.
-
|
OK, here you go. https://github.com/martinrotter/rssguard/tree/master/resources/skins/plain Just clone to your user data folder. I added some commentary into |
Beta Was this translation helpful? Give feedback.
-
|
Thank you, great commentaries, too! |
Beta Was this translation helpful? Give feedback.
-
|
I was wondering, why does the Qt stylesheet file bear the extension of Isn't it awfully confusing? Why not |
Beta Was this translation helpful? Give feedback.
-
|
Why |
Beta Was this translation helpful? Give feedback.
-
|
Anyway, if you create your own custom skin, mind sharing screenshot when it's done? |
Beta Was this translation helpful? Give feedback.
-
|
I rather open a PR, if this should be the case. Qt-styling is still only in dreams, by the way. |
Beta Was this translation helpful? Give feedback.
-
|
Well, I decided to give it a try, since I am familiar with it, still WIP though.
I am totally happy with such plain style, as it looks really natural; "Published on" won't be translated, of course, so I guess I'd need to change that part. P.S. I really miss SCSS... |
Beta Was this translation helpful? Give feedback.
-
|
Looks cute. I perfonally find "Link" and "Published on" redundant, but other than that it looks fine. Thing is that these things are heavily user-dependent. Everyone like something else. Feel free to create PR with the theme, choose the name as you please. I will merge. |
Beta Was this translation helpful? Give feedback.
-
Right... I am still not sure what should I do with the header... |
Beta Was this translation helpful? Give feedback.
I see. I did some testing with the style and it worked. I agree that CSS style is rather problematic part of the app, because contents of articles are very diverse and often (semi)-broken.
I will revert
vergiliusto previous version and will introduce new skin instead with different name. Also, as you probably are familiar with possibility of having your own skins.