Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IRequestHandler to return ValueTask instead of ValueTask<Unit> #103

Open
Dreamescaper opened this issue Jul 6, 2023 · 1 comment
Open

Update IRequestHandler to return ValueTask instead of ValueTask<Unit> #103

Dreamescaper opened this issue Jul 6, 2023 · 1 comment

Comments

@Dreamescaper
Copy link

I assume that this type was added for compatibility with MediatR. However, it is removed in latest MediatR versions - which is a good thing in my opinion, as it is much cleaner to write Task return type instead of Task<Unit>.

Does it make sense to remove it in the next major version?
@Dreamescaper Dreamescaper changed the title Remove Unit type Update IRequestHandler to return ValueTask instead of ValueTask<Unit> Jul 7, 2023
@martinothamar
Copy link
Owner

Probably, I'll look into it as part of 3.0. It makes sense to keep up with MediatR API as much as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinothamar @Dreamescaper