Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search when invoked should get prefilled from the currently selected text #1729

Closed
1 task done
hrvojegolcic opened this issue Nov 20, 2019 · 5 comments · Fixed by #2572
Closed
1 task done

Search when invoked should get prefilled from the currently selected text #1729

hrvojegolcic opened this issue Nov 20, 2019 · 5 comments · Fixed by #2572
Labels
🐮 good first issue Good for new comers 🦋 optimization Improve the existing behavior

Comments

@hrvojegolcic
Copy link

Description

Unlike the global search (Ctrl+Shift+F) the local search (Ctrl+F) when invoked gets prefilled from the currently selected text as a search query.

I don't know if the behavior is intentional but in my opinion the global search should also get prefilled from the currently selected text.

  • Can you reproduce the issue?

Steps to reproduce

  1. Select some text within the current document
  2. Press Ctrl+Shift+F to invoke the global search
  3. The global search sidebar appears

Expected behavior:

The search query input field should receive the focus.
The search query input field should be prefilled from the currently selected text, similarly how the local search is implemented.

Actual behavior:

The search query input field is not focused nor prefilled.

Versions

  • Mark Text: 0.15.x and 0.16.x
  • Operating system: Win 8.1
@fxha fxha added the 🦋 optimization Improve the existing behavior label Nov 24, 2019
@fxha fxha added the 🐮 good first issue Good for new comers label Dec 21, 2019
@MaanasArora
Copy link

Can I work on this issue?

@Jocs
Copy link
Member

Jocs commented Feb 6, 2020

@MaanasArora Yes, you are always welcomed to make PRs.

@Ricardo-HE
Copy link

@MaanasArora Did you manage to solve the issue? If not I would like to work on it as well :)

@Henry78
Copy link

Henry78 commented Jul 29, 2020

As of v16 (see #1311) the search box is prefilled with currently highlighted text in global search. But the box is still not focussed. And I'm not able to unfocus/return on hitting 'Esc'

@Henry78
Copy link

Henry78 commented Jul 29, 2020

I added the more specific issue #2294 for the unimplemented parts of this issue. So I think this issue may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐮 good first issue Good for new comers 🦋 optimization Improve the existing behavior
Projects
None yet
6 participants