Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option for multiple Configuration #54

Open
karthik-krishnan opened this issue Jul 24, 2017 · 9 comments
Open

An option for multiple Configuration #54

karthik-krishnan opened this issue Jul 24, 2017 · 9 comments

Comments

@karthik-krishnan
Copy link

Typically in Enterprises, there are multiple groups of projects monitored and hence each group would have a page for itself. It would be great if one can have multiple config json files and a unique url to render the dashboard based on the specific config.

This allows for us to have multiple tabs in browser (one for each group) and switch them on a timer.
In the current implementation of the node-build-monitor, i will have to run multiple instances of the node app on different ports as a workaround

@marcells
Copy link
Owner

Hi, sounds like a very good idea. This could be an easy, but breaking change for the build monitor configuration. I'll think about, how to implement this.

@marcells
Copy link
Owner

I've made a quick implementation in the feature branch multi-configuration. There are still several things to do (client settings, refactoring, concept for naming the groups, ...). Maybe you can take a look at it and tell me, if it is working in the way you imagined.

@karthik-krishnan
Copy link
Author

karthik-krishnan commented Jul 27, 2017 via email

@marcells
Copy link
Owner

marcells commented Aug 1, 2017

Thank you. Maybe you can give me some input. I'd like to implement an easy solution first. If possible, without breaking changes for existing solutions.

@karthik-krishnan
Copy link
Author

karthik-krishnan commented Aug 3, 2017 via email

@marcells
Copy link
Owner

marcells commented Aug 5, 2017

Hi,

sorry for the late response.

  1. The port is defined by the PORT-environment variable.
  2. The configuration is now an array of monitor configurations, instead of a single object. If you have multiple configurations (monitors) and you launch the main page of the build monitor, you'll see a list of all available monitors, which links to each monitor. The links have the following schema: http://localhost:3000/monitor/{monitorId}.

Great, good to know, that your colleague will help. If I find some time tomorrow, I'll resume coding this feature. I hope we won't run into any conflicts. ;-)

Kind regards
Marcell

@carltonmason
Copy link

@karthik-krishnan suggestion is excellent. Perhaps instead of a separate unique page/tab per monitor, have a single page with a column per configured monitor job. That way you can see them all on the same page by looking left to right and scroll down for build history.

@marek-ganko
Copy link

Hi @marcells,
Any plans on merging this feature branch with multiple configurations to master?

@marcells
Copy link
Owner

marcells commented Feb 1, 2018

Hi, currently there is still some work to do. If someone could continue my (exprrimental) work of feature branch https://github.com/marcells/node-build-monitor/tree/feature/multi-configuration would be good. I have no time at the moment to continue active development of this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants