Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust readme and martin book #1253

Merged
merged 27 commits into from
May 26, 2024
Merged

Adjust readme and martin book #1253

merged 27 commits into from
May 26, 2024

Conversation

sharkAndshark
Copy link
Collaborator

@sharkAndshark sharkAndshark commented Mar 15, 2024

Try to fix #1245

Add or keep

  • Add a Get Started to readme, it must be easy to take, like curl -O .. and then martin http://xxx.demo.pmtiles I guess? OR docker run .. with a small http://xxx.demo.pmtiles, do we have some host to serve a demo pmtiles file?
  • Keep License in readme

Move or remove from readme.md

  • Move Re-use Martin as a library to book
  • Move installation from readme to book
  • Remove Running Martin Service
  • Remove API from readme

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for working on this!!

@@ -14,107 +14,6 @@ Additionally, there are [several tools](https://maplibre.org/martin/tools.html)

See [Martin book](https://maplibre.org/martin/) for complete documentation.

## Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create some something like a list of important information, and point it to the book - e.g. installation should point directly to the installation section, etc. Just the most important topics, not everything?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

Helpful Martin docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but without the header - just a few links. We may also want to add a "quick start" - makes novice users go there first

docs/src/Re-use-Martin-as-a-library.md Outdated Show resolved Hide resolved
docs/src/installation.md Outdated Show resolved Hide resolved
README.md Outdated
* [Installation](https://maplibre.org/martin/installation.html)
* Running with [CLI](https://maplibre.org/martin/run-with-cli.html) or [configuration file](https://maplibre.org/martin/config-file.html)
* [Usage and API](https://maplibre.org/martin/using.html)
<!-- * [Quick Start](https://maplibre.org/martin/quick-Start.html) -->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bypass the markdwon link check, this line is removed temporally. Will be added after this get merged.

@sharkAndshark sharkAndshark requested a review from nyurik May 11, 2024 03:33
@sharkAndshark sharkAndshark marked this pull request as ready for review May 11, 2024 03:33
@nyurik
Copy link
Member

nyurik commented May 11, 2024

will review shortly. One thing for sure - i don't think we want to use case-sensitive dir name like Images - use img or images instead

@nyurik
Copy link
Member

nyurik commented May 11, 2024

P.S. and same for the filename -- Re-use-Martin-as-a-library.md caps don't work well, esp when some people use windows (which is case insensitive) vs linux (which is case sensitive).

Perhaps a better name is martin-as-library or using-martin-as-lib or something like that?

@nyurik
Copy link
Member

nyurik commented May 26, 2024

Great work, thanks!!! It gave me a good start to continue improving it. Especially big thx for the QGIS doc images, they make things much easier for the novice users.

@nyurik nyurik merged commit a9cb0c9 into maplibre:main May 26, 2024
1 of 2 checks passed
@sharkAndshark sharkAndshark deleted the readme branch May 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce README, moving more things to the book
2 participants