Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect old postgresql versions and warn user #1230

Open
3 tasks
nyurik opened this issue Mar 5, 2024 · 2 comments
Open
3 tasks

Detect old postgresql versions and warn user #1230

nyurik opened this issue Mar 5, 2024 · 2 comments
Assignees
Labels
good first issue help wanted pg Related to PostgreSQL sources

Comments

@nyurik
Copy link
Member

nyurik commented Mar 5, 2024

As asked in #1229, postgres 9.6 had different schema discovery structure, and yet we do not tell users that their postgresql db is too old and there might be an issue.

What we need is:

  • Query Postgres version (similar to how we currently detect Postgis version)
    • There are two ways: select version() good for printing as part of the [info] text, and SHOW server_version (or SELECT current_setting('server_version') ?) for a semver variant that can be used for testing.
  • Report postgres version string to the user
  • If postgres version is older than whichever version we currently support (some global const), give a warning, and note that that postgres is no longer maintained
@vatsa287
Copy link

vatsa287 commented Mar 6, 2024

@nyurik I am interested in working on this & get to know the codebase more. Could you please assign this to me?

@nyurik
Copy link
Member Author

nyurik commented Mar 6, 2024

sure thing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted pg Related to PostgreSQL sources
Projects
None yet
Development

No branches or pull requests

2 participants