-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Auto] Remove direct MapboxNavigation
references
#6141
Labels
Comments
Before refactoring this entirely, there should be consensus on this #6143 |
This was referenced Aug 23, 2022
This was referenced Sep 1, 2022
This was referenced Sep 14, 2022
All done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
All of the direct references to
MapboxNavigation
are to be deleted from the public api in favor ofMapboxNavigationObserver
orMapboxNavigationApp.current()
.The
MapboxNavigationApp
did not exist during the original implementation, so only the most recent implementations are using theMapboxNavigationApp
. This refactor will unlock the ability to disable and enableNavigationOptions
at runtime.When choosing to use
MapboxNavigationObserver
vsMapboxNavigationApp.current()
MapboxNavigationObserver
when registering for continuous data streamsMapboxNavigationApp.current()
for special cases, typically when a single is neededHere is a list of classes that need to be migrated.
MapboxNavigation
fromRoutePreviewCarContext
#6226MapboxNavigation
fromCarNavigationInfoObserver
constructor #6263MapboxNavigation
fromCarLocationsOverviewCamera
constructor #6225MapboxNavigation
fromCarNavigationCamera
andCarRouteLine
#6219MapboxNavigation
fromCarNavigationCamera
andCarRouteLine
#6219The text was updated successfully, but these errors were encountered: