Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Auto] Remove direct MapboxNavigation references #6141

Closed
15 tasks done
kmadsen opened this issue Aug 9, 2022 · 2 comments
Closed
15 tasks done

[Android Auto] Remove direct MapboxNavigation references #6141

kmadsen opened this issue Aug 9, 2022 · 2 comments
Labels
Android Auto Bugs, improvements and feature requests on Android Auto. jira-sync-complete

Comments

@kmadsen
Copy link
Contributor

kmadsen commented Aug 9, 2022

All of the direct references to MapboxNavigation are to be deleted from the public api in favor of MapboxNavigationObserver or MapboxNavigationApp.current().

The MapboxNavigationApp did not exist during the original implementation, so only the most recent implementations are using the MapboxNavigationApp. This refactor will unlock the ability to disable and enable NavigationOptions at runtime.

When choosing to use MapboxNavigationObserver vs MapboxNavigationApp.current()

  • Use MapboxNavigationObserver when registering for continuous data streams
  • Use MapboxNavigationApp.current() for special cases, typically when a single is needed

Here is a list of classes that need to be migrated.

@kmadsen kmadsen added the Android Auto Bugs, improvements and feature requests on Android Auto. label Aug 9, 2022
@kmadsen
Copy link
Contributor Author

kmadsen commented Aug 10, 2022

Before refactoring this entirely, there should be consensus on this #6143

@kmadsen
Copy link
Contributor Author

kmadsen commented Dec 14, 2022

All done

@kmadsen kmadsen closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Auto Bugs, improvements and feature requests on Android Auto. jira-sync-complete
Projects
None yet
Development

No branches or pull requests

2 participants