Skip to content
This repository has been archived by the owner on May 9, 2018. It is now read-only.

Compass tracking issues #55

Closed
russellquinn opened this issue Jun 28, 2012 · 30 comments
Closed

Compass tracking issues #55

russellquinn opened this issue Jun 28, 2012 · 30 comments
Labels
Milestone

Comments

@russellquinn
Copy link

  1. The rotation of the map is wrong for anything other than portrait orientation. (It's out by the number of degrees the device has been physically rotated.)
  2. Changing the orientation of the view while compass tracking correctly keeps the confidence circle centered, but the blue dot is not re-centered (screenshot: https://dl.dropbox.com/u/44154592/compassRotating.png)
  3. The blue dot doesn't change to use the compass tracking graphic used in Maps.
  4. Less important, but the rotation is very jerky compared to Maps.
@incanus
Copy link
Contributor

incanus commented Jun 28, 2012

See also #40.

@incanus
Copy link
Contributor

incanus commented Jul 23, 2012

For 1., sorry if I'm being dense here, but does it behave differently from Maps.app?

@russellquinn
Copy link
Author

Yep, Maps rotates the view, but north is still north. If you rotate a MapBox map, then north is no longer north.

@russellquinn
Copy link
Author

(I'll email you a video.)

@incanus
Copy link
Contributor

incanus commented Jul 26, 2012

  1. Still working on it.
  2. Thanks for this. Should be fixed above.
  3. Not sure what you mean.
  4. Will try to get to this.

@russellquinn
Copy link
Author

  1. I just mean that in Maps.app there's a "flashlight path" graphic around the blue dot showing that it's in "compass mode," which MapBox doesn't have. It's pretty useful as a reminder that you're in compass mode, etc.

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

You should have that -- are you copying all of the Resources into your app? While we don't have the varying widths on the path representing relative heading accuracy (yet), we do have one image in there that looks pretty good IMHO.

@russellquinn
Copy link
Author

True, yes, but it's not showing. I'm pulling the latest from Develop straight into my project. The image is there and I single-stepped though the part where it's loaded and added to the view and, it loads properly, but it's not visible. I just get a naked blue dot in heading mode.

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

Hmm, I've never seen that before. This is on device, yes, so as to not be faking compass mode?

@russellquinn
Copy link
Author

Yep, on both a real iPad and iPhone. Check out the latest beta of our app? Most of these things I'm reporting are demonstrable there.

trasch added a commit to Outdooractive/route-me that referenced this issue Jul 27, 2012
@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

Yeah, seeing the lack of path image. Can't replicate that either :-) Will keep at it.

@russellquinn
Copy link
Author

You mean, you're seeing no path image in our app beta, but can't replicate it in other SDK uses?

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

I'm seeing no image in your beta, but I can't get it to happen anyplace else.

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

Re: the path image, can you double-check a couple things?

  1. Does the alpha ever get set to 1.0? See https://github.com/mapbox/mapbox-ios-sdk/blob/develop/MapView/Map/RMMapView.m#L2616-2620
  2. What is the ordering like on the RMMapView subviews? I.e., is the path image on top of the scroll view, overlay view, etc.
  3. Try debug-printing the position/frame/bounds of the image view in question and make sure it's sane.

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

I just realized my misunderstanding of your north/rotation issue -- I've been looking at iPhone apps that don't rotate with device orientation. Thanks, your video was helpful there. On it.

@incanus
Copy link
Contributor

incanus commented Jul 27, 2012

Ok, as of 8d84650 and d4adab7, there should be proper device orientation compensation, as well as some other nice improvements to heading updates. I think that other than the animation jerkiness (which I might spin off into another, lower priority ticket), we just have your app's specific problem with the heading graphic now.

Just to confirm, you see this behave properly over in MapBox Me, right? I.e., your experience matches the screenshot?

@russellquinn
Copy link
Author

Observations, based on latest MapBox Me (and latest SDK from 'develop' branch):

  1. The rotation of the map is still wrong when the device is orientated.
  2. When in heading mode, the blue dot now stays centered when rotating the device, but the accuracy circle disappears, then flies in again from off screen.
  3. When rotating the device and NOT in heading tracking mode, the blue dot also animates in from an incorrect location, as described in 2.
  4. Entering heading tracking mode, then swiping, rotating, etc. a bunch until the mode cancels often leaves it in a state where pinch-zooming no longer works.
  5. The heading graphic DOES appear in MapBox Me. I'll try investigating why it doesn't in our app further.

@incanus
Copy link
Contributor

incanus commented Jul 31, 2012

I'm not changing MapBox Me, FWIW, right now -- just the SDK.

@russellquinn
Copy link
Author

I was using MapBox Me with the latest SDK. All these issues (except 5) are the same with the latest SDK in our app too.

@incanus
Copy link
Contributor

incanus commented Jul 31, 2012

Man, I just can't replicate any of these in testing on a iPhone 4S and iPad 3. Hmm.

@russellquinn
Copy link
Author

Well, a little bit of good news, I removed the SDK from our app and re-added, and the heading graphic now appears! So that's no longer a problem.

@incanus
Copy link
Contributor

incanus commented Jul 31, 2012

I'm guessing maybe the image thing was related to a reference link that went awry somehow and not an actual copy into the project (which is fine; I do the reference myself).

@incanus
Copy link
Contributor

incanus commented Jul 31, 2012

Re: device orientation, does it work any better in 451bbc0 and before?

@incanus
Copy link
Contributor

incanus commented Jul 31, 2012

Definitely nailed a bug here now in bf9054d.

@incanus
Copy link
Contributor

incanus commented Aug 1, 2012

Re: the accuracy circle swooping in, this is a general annotation issue that I filed upstream in Outdooractive/route-me#95. Not sure what to do there yet.

@russellquinn
Copy link
Author

Device orientation / heading tracking seems to be working now!!

@incanus
Copy link
Contributor

incanus commented Aug 7, 2012

Cool, so I think we're set here now that smooth animation is over in #84?

@russellquinn
Copy link
Author

If the animation problem when rotating is a Route-Me problem then I guess so, yeah. Did we fix:

Entering heading tracking mode, then swiping, rotating, etc. a bunch until the mode cancels often leaves it in a state where pinch-zooming no longer works.

?

@incanus
Copy link
Contributor

incanus commented Aug 7, 2012

Whoops, yeah, missed that (lotta stuff here). Will leave open.

@incanus
Copy link
Contributor

incanus commented Aug 8, 2012

Ok, going to close this lengthy ticket in favor of piecing the remaining tasks out.

Let me know if I missed any other outstanding issues here.

@incanus incanus closed this as completed Aug 8, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants