-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server panic when query page[size]=0 #305
Comments
Oh that is not supposed to happen. Thanks for reporting! Instead of implicitly assuming that zero should be the defaultSize, I'd rather handle invalid cases with a bad request. If you'd like or it's urgent you you open a PR with a test, but if not, we will take a look at it :) |
I validated the page[size] parameter in the PaginatedFindAll function and returned a BadRequest error message if it was zero. This problem is not very serious, but you should check back later. I think the way to solve this problem may be related to #306. |
When calling PaginatedFindAll with query page[size]=0, the server returns the following error:
I think PaginatedFindAll should return the defaultSize. When query page[size]=0 will assign size = defaultSize.
Another problem is that when I want to limit the size (eg max = 10), what should I do?
The text was updated successfully, but these errors were encountered: