-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why readFileSync instead of async readFile? #92
Comments
The whole i18n live update thing is still very early stage. I don't remember why I chose the synchronous versions over the async ones, there might have been a reason, but I honestly don't remember it. I will keep it in mind and consider rewriting it using the async versions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
I'm wondering why you used
readFileSync
andstatSync
in thei18n
middleware, here:react-ssr-setup/src/server/middleware/i18n.ts
Line 39 in 21e6dfe
It could probably be changed to use the async versions, or is there a specific reason(s) you chose the sync/blocking versions?
The text was updated successfully, but these errors were encountered: