Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTER distributed #1771

Closed
sanikolaev opened this issue Jan 29, 2024 · 11 comments · Fixed by #2188
Closed

ALTER distributed #1771

sanikolaev opened this issue Jan 29, 2024 · 11 comments · Fixed by #2188
Assignees
@PavelShilin89
Labels
buddy_candidate est::size_S

Comments

@sanikolaev
Copy link
Collaborator

Currently to update a distributed table in RT mode you have to do DROP TABLE / CREATE TABLE. Let's wrap it into ALTER TABLE .... The syntax is to be specified and discussed.
@AbstractiveNord AbstractiveNord mentioned this issue Jan 29, 2024
Open
@sanikolaev
Copy link
Collaborator Author

CREATE TABLE ... WITH REPLACE can be implemented in the future and used here to provide atomicity (estimate: ~ half a work day).

Another challenge is to make it support replication, so the same alter is propagated to the other nodes OR make a protection from that.

@djklim87
Copy link
Contributor

djklim87 commented May 9, 2024

Syntax is

alter table `dist` local='t1' local='t3';

@djklim87
Copy link
Contributor

djklim87 commented May 9, 2024 •
edited

Waiting for approve https://github.com/manticoresoftware/buddy-core/pull/47/files

@djklim87
Copy link
Contributor

Waiting for review manticoresoftware/manticoresearch-buddy#283

@djklim87 djklim87 assigned donhardman and unassigned djklim87 May 13, 2024
@donhardman donhardman assigned djklim87 and unassigned donhardman May 13, 2024
@djklim87
Copy link
Contributor

djklim87 commented May 13, 2024 •
edited

  • update docs

@djklim87 djklim87 mentioned this issue May 13, 2024
Merged
@djklim87
Copy link
Contributor

Waiting for docs review #2167

@djklim87 djklim87 assigned sanikolaev and unassigned djklim87 May 13, 2024
@sanikolaev
Copy link
Collaborator Author

sanikolaev commented May 15, 2024 •
edited

Waiting for docs review #2167

Reviewed and merged.
Updated the changelog.

@sanikolaev
Copy link
Collaborator Author

@PavelShilin89 pls add tests.

@PavelShilin89 PavelShilin89 linked a pull request May 16, 2024 that will close this issue
Test/alter distributed #2188
Merged
@PavelShilin89
Copy link
Contributor

Blocked by #2190

@sanikolaev
Copy link
Collaborator Author

Blocked by #2190

Unblocked.

@PavelShilin89
Copy link
Contributor

Done in #2188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PavelShilin89 PavelShilin89

Labels
buddy_candidate est::size_S
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test/alter distributed manticoresoftware/manticoresearch
4 participants
@djklim87 @sanikolaev @donhardman @PavelShilin89