-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Conti hashing algorithm to MurmurHash2 #114
Comments
I totally overlooked this being MurMurHash2, so my bad on that 😞. Tested this implementation this morning, but I ran into a lot of trouble from the array package and couldn't get it to work. Also, this one on Pypi doesn't work with both murmur2 and murmur3 for some reason. Pretty sure I give the right seed and all that. I think I would go with renaming the algorithm from Conti to Murmur, but it might be helpful if someone else can also check this. I might just be missing something in my script 😓 |
For reference the Conti hashing algorithm is MurmurHash2 - not sure if it would be advisable to leverage an existing package for this MurmurHash2, or what is on Pypi, or simply rename the algorithm from Conti.
Originally posted by @ddash-ct in #112 (comment)
The text was updated successfully, but these errors were encountered: