-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strutils.plural
does not handle acronyms correctly
#291
Comments
Good point, I'd take a PR for that if you want to take a swing at it. :)
…On Tue, Aug 3, 2021 at 6:27 PM Mike Hucka ***@***.***> wrote:
If the word to be pluralized is an acronym like "DOI", then plural will
match case and produce "DOIS", which is not the desired result in many
(most?) cases. A better result would be "DOIs", to match its use in
sentences such as "There are a total of 53 DOIs associated with this
journal".
I realize this is a difficult case, because it's basically impossible for
plural to recognize every conceivable acronym. Perhaps a better solution
would be to have some kind of option or override on the case-matching part
of the code, such that the user could say "don't match case".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#291>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7ZEMVKXI7RM3ZPWOJHXLT3CJOPANCNFSM5BP7USVA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the word to be pluralized is an acronym like "DOI", then
plural
will match case and produce "DOIS", which is not the desired result in many (most?) cases. A better result would be "DOIs", to match its use in sentences such as "There are a total of 53 DOIs associated with this journal".I realize acronyms are especially challenging, because it's basically impossible for
plural
to recognize every conceivable acronym. Perhaps a better solution would be to have some kind of option or override on the case-matching part of the code, such that the user could say "don't match case".The text was updated successfully, but these errors were encountered: