Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error in tilde expansion #193

Open
3 tasks
Tracked by #260
magicant opened this issue Sep 13, 2022 · 0 comments
Open
3 tasks
Tracked by #260

Report error in tilde expansion #193

magicant opened this issue Sep 13, 2022 · 0 comments
Labels
tracker List of subtasks

Comments

@magicant
Copy link
Owner

The current implementation ignores any errors in tilde expansion. The expansion should fail if there is an error so that the user can notice the error more easily.

For the error message to include an annotated source code snippet, the WordUnit::Tilde variant needs to carry its originating location, and that requires the TextUnit::Literal variant to have a location in turn.

  • Let TextUnit::Literal carry its location
  • Let WordUnit::Tilde carry its location
  • Let tilde expansion fail on error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracker List of subtasks
Projects
Status: To do
Development

No branches or pull requests

1 participant