Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawner in Env #146

Open
3 tasks
magicant opened this issue Apr 4, 2022 · 1 comment
Open
3 tasks

Spawner in Env #146

magicant opened this issue Apr 4, 2022 · 1 comment
Projects

Comments

@magicant
Copy link
Owner

magicant commented Apr 4, 2022

Consider holding a local spawner in Env instead of in VirtualSystem's state. It might be useful even with RealSystem when implementing here-document and virtual subshell, for example.

  • Move Executor from yash_env::system::virtual to yash_env
  • Move executor from SystemState to Env
  • Remove executor from DummyChildProcess
@magicant magicant created this issue from a note in Main (In progress) Apr 4, 2022
@magicant
Copy link
Owner Author

magicant commented Apr 4, 2022

I'm not sure if this idea is worth doing, so I give it a low priority now.

  • Implementing here-documents with virtual child processes that write to a pipe would require blocking SIGPIPE and complicate signal handling. I'd rather implement them with a temporary file.
  • implementing virtual subshells requires much consideration. It is not yet very clear if having a spawner in Env contributes to a better design.

@magicant magicant moved this from In progress to To do in Main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Main
  
To do
Development

No branches or pull requests

1 participant