Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger signing: preview hash #659

Open
styts opened this issue Jun 4, 2022 · 4 comments
Open

Ledger signing: preview hash #659

styts opened this issue Jun 4, 2022 · 4 comments

Comments

@styts
Copy link

styts commented Jun 4, 2022

When signing an operation on the Ledger device, the device shows a preview of the operation hash.

It would bring peace of mind if Temple also displayed the hash so one could be assured that the hashes match.

@unixvb
Copy link
Contributor

unixvb commented Jun 8, 2022

Hi, totally make sense.
Thanks

@unixvb unixvb reopened this Jul 20, 2022
@unixvb
Copy link
Contributor

unixvb commented Sep 2, 2022

@styts do you know how the Ledger Tezos app generates Sign Hash?
I'm trying to find find the algorithm they are using but have had no success.

For example, here's hex representation of the buffer that is sent to Ledger

80048100a5034ba91af95397bab6bbab70d9c7e4bd10d7690b65f142a38a147766b53ff1e24e6c00a32ccb728161bfcb4ef6ecf27a57e60ab7c3d36fea099d91f908d74500c0843d01877000f8da63709e9d080fe4670dc8ab96b7e3e800ffff1174657a546f546f6b656e5061796d656e740000003407070089b9d8d4b69dab3f0100000024747a31615770566e386b35615a765661434b504d64635065583863636d35363632534c4c

Ledger Sign Hash

45zn4REnq2Fe4AQwEr8Pd6BaV1WPMoqJAasPVmbXTBtb

@unixvb
Copy link
Contributor

unixvb commented Sep 2, 2022

Maybe there is a problem with the Ledger Tezos app.

When I'm trying to sign a massage in Ethereum Ledger App I see Message Hash, but when I'm trying to sign a massage in Tezos Ledger App I see Sign Hash.

If Sign Hash means "signature hash" - it's not possible to generate it on the wallet, cuz private keys are stored on the Ledger.

@styts
Copy link
Author

styts commented Sep 5, 2022

Have you looked at the app repo? https://github.com/obsidiansystems/ledger-app-tezos
Hope this helps, I don't know much further. Maybe reach out to Obsidian devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants