-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAME tags are not parsed, leading to an incorrect length calculation #263
Comments
This was referenced Jan 14, 2024
5 tasks
Am I understanding this correctly, that this wouldn't just need the parsing of the In the SFML tests we're getting a relatively large difference in time and sample count. Additionally, the first few samples seem to be zero values instead of the actual sample. Values on the right is what minimp3 reported:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When decoding https://github.com/py-sdl/py-sdl2/blob/master/sdl2/test/resources/soundtest.mp3, the correct length is 0.1502 seconds, but when using dr_mp3, the reported length is 0.209 seconds.
This can cause silence to be played incorrectly, which is especially a problem when looping MP3 files.
This was reported to SDL_mixer in libsdl-org/SDL_mixer#439 and was solved by switching from dr_mp3 to minimp3.
The text was updated successfully, but these errors were encountered: