Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Allow requesting spot instance instead of an on-demand instance. #169

Open
ohinds opened this issue Sep 19, 2023 · 7 comments · May be fixed by #171
Open

[feature request] Allow requesting spot instance instead of an on-demand instance. #169

ohinds opened this issue Sep 19, 2023 · 7 comments · May be fixed by #171

Comments

@ohinds
Copy link

ohinds commented Sep 19, 2023

It would be nice to be able to request a spot instance when it fits the use-case, to reduce cost.

I think it would be straightforward to add a conditional in startEc2Instance (or another function entirely) to call requestSpotInstances instead of runInstances here.
@Preen
Copy link

Preen commented Oct 3, 2023

+1

@troinine
Copy link

This would be a great addition. The current AWS SDK for Javascript v2 EC2.runInstances() allows definition of market options which would probably serve a good amount of use cases.

requestSpotInstances is deprecated and should not be used as per https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-best-practices.html#which-spot-request-method-to-use

@tknisch
Copy link

tknisch commented Nov 23, 2023

+1 for this!

@troinine troinine linked a pull request Nov 24, 2023 that will close this issue
Open
@troinine
Copy link

Proposing to address this with #171. I have conducted few tests with an actual AWS account.

@Preen
Copy link

Preen commented Nov 24, 2023

If I look at the pull requests, Im a bit worried that this repo isnt maintained anymore?

@Preen
Copy link

Preen commented Nov 24, 2023

@tonyhutter u were the last to commit changes to this Repo. Maybe you can take a look at the proposed solution?

@Dmitry1987
Copy link

If I look at the pull requests, Im a bit worried that this repo isnt maintained anymore?

the maintainer is looking for others who can take over the support and maintenance #172 i proposed to help, will do my best within limited scope, but we need more people 💯 . let's see what the decision will be. not many chime in so far though 😓 because nobody sees the announcement, it should be inserted to the readme header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for using spot instances troinine/ec2-github-runner
5 participants
@Preen @ohinds @Dmitry1987 @troinine @tknisch