Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop action fails to find Github runner though the labeled runner does exist #119

Open
scottdickerson opened this issue Oct 21, 2022 · 2 comments

Comments

@scottdickerson
Copy link

scottdickerson commented Oct 21, 2022

This results in lots of offline runners piling up in our repository. The EC2 instance is killed successfully but the runner isn't removed

image

Run machulav/ec2-github-runner@v2
  with:
    mode: stop
    github-token: ***
    label: shk8d
   <removed for security>
    aws-resource-tags: []
  env:

    AWS_DEFAULT_REGION: <removed>
    AWS_REGION: <removed>
    AWS_ACCESS_KEY_ID: ***
    AWS_SECRET_ACCESS_KEY: ***
AWS EC2 instance <removed-for-security> is terminated
GitHub self-hosted runner with label shk8d is not found, so the removal is skipped
@scottdickerson
Copy link
Author

I think another possible fix for this is to just allow us to create these tagged as ephemeral runners and github will supposedly remove them automatically after 1 day (instead of 30 days)

@scottdickerson
Copy link
Author

this turned out to be a permissions problem with my github-token. I think we would have caught this issue much sooner if this line was improved to actually show the error:

return null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant