Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address caveats katalog update script #222

Open
5 tasks
ckadner opened this issue Sep 23, 2021 · 1 comment · May be fixed by #354
Open
5 tasks

Address caveats katalog update script #222

ckadner opened this issue Sep 23, 2021 · 1 comment · May be fixed by #354
Assignees
Labels
help wanted Extra attention is needed

Comments

@ckadner
Copy link
Member

ckadner commented Sep 23, 2021

We need to address (some of) the current caveats in the catalog update script:

  • move script from /hack to /tools/python
  • add developer documentation
  • clone the katalog repo into a temp directory instead of relying on the user to have done it prior to running the script
  • not all of the YAML files in the katalog repo may want to be included in the catalog upload, so alert the user to all the changes instead of relying on git diff
  • read the catalog_upload.json file prior to regenerating it to capture assets that live outside the katalog repo and re-add them later

Originally posted by @ckadner in #200 (comment)

@ckadner ckadner self-assigned this Sep 23, 2021
@ckadner ckadner removed their assignment Feb 2, 2022
@ckadner ckadner added the help wanted Extra attention is needed label Feb 2, 2022
@JiaxuanYang
Copy link
Contributor

Hi @ckadner, could you please assign this issue to me? Thank you!

@JiaxuanYang JiaxuanYang linked a pull request Jul 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants