Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometime asyncBusboy never responding #56

Open
yjinchoi opened this issue Jul 6, 2023 · 2 comments
Open

Sometime asyncBusboy never responding #56

yjinchoi opened this issue Jul 6, 2023 · 2 comments

Comments

@yjinchoi
Copy link

yjinchoi commented Jul 6, 2023

Sometimes I found that asyncBusboy not responding because promise never resolved or rejected.
I traced inside asyncBusBoy source code and I found that sometimes request's 'close' event handler called
before busboy's 'finish' handler ( before onEnd called).
I modified source code like "request.on('close', onEnd)" instead of "request.on('close', cleanup)" and it works perfectly.
I'm afraid I'm doing wrong and make some side effects. Replacing handler to onEnd instead of cleanup is safe?

@lkraav
Copy link

lkraav commented Feb 28, 2024

Probably duplicate of #49

@ardelio
Copy link

ardelio commented Apr 13, 2024

I don't think the issue is with async-busboy, but instead Koa.

NodeJS http library is closing the request when I would expect it not to. The issue here is, I think, figuring out why http is issuing the close event, when we are in the depths of our application code 🤔

jeffrinmathewbenny added a commit to jeffrinmathewbenny/async-busboy that referenced this issue May 22, 2024
jeffrinmathewbenny added a commit to jeffrinmathewbenny/async-busboy that referenced this issue May 22, 2024
jeffrinmathewbenny added a commit to jeffrinmathewbenny/async-busboy that referenced this issue May 22, 2024
async-busboy-freeze-fix: fix the async-busboy freeze issue mentioned m4nuC#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants