-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Think about alternative to sails.config.i18n.requestLocale #34
Comments
May you please add a spec/scenario that fail the current implementation. As far as sails hook implementation is concern and regardless of the number request all request will be processed to obtain their locale. Is it bad idea is attaching locale to a request object?. If so am open for the correct implementation. |
Got that. |
Thanks. |
@rishabhmhjn I don't see how you proposition fixes anything. You set a property on a global. The I can't think of a way of fixing the problem without a reference to the request in the |
Using
sails.config.i18n.requestLocale = request.getLocale();
is a bad idea!It assumes that all the requests are processed serially and so, parallel requests will fail to get the correct locale!
https://github.com/lykmapipo/sails-hook-validation/blob/master/index.js#L73
The text was updated successfully, but these errors were encountered: