-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffolding: 'react-router' version '6.0.0-beta.8' not working for new gateway #1831
Comments
I am seeing the same with new custom gateways created from the scaffolder.
It looks like the culprit is I believe this is the nested route that falls foul of the new behaviour...
You can work around this by using a Yarn selective dependency resolver to resolve the
I tried |
Description
After creating new gateway with
make scaffold-gateway
command, upon starting it there were some errors on the frontend.Expected Behavior
Starting new gateway project should result in working frontend.
Actual Behavior
New gateway project's frontend is not working.
Version
d24c8d8
Other Context
Resolution
This problem was tracked down to be due to the version of
react-router
that was installed in the new gateway project.This project has
"react-router": "^6.0.0-beta"
configured in thefrontend/packages/core/package.json
file. However, at the time it was added this resulted in the version6.0.0-beta.0
to be locked inyarn.lock
file.Since the new gateway project depends on the
@clutch-sh/*
modules, it tries to resolve"react-router": "^6.0.0-beta"
version, which currently resolves in locking6.0.0-beta.8
version. As it can be observed, there were 8 beta releases for thereact-router
, and at some point there were some incompatible changes.I've solved this problem by just locking
6.0.0-beta.0
version, however same issue will be present for anyone other trying to create new gateway.Initially I though to create a PR for this, however due to the nature of problem I figured some other solution from mine (which was just to have exact version in
package.json
) might be preferred.The text was updated successfully, but these errors were encountered: