Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Relative Path for Including lvgl.h in lv_rnd_unicodes.h #6117

Closed
1saeed opened this issue Apr 23, 2024 · 2 comments · Fixed by #6141
Closed

Incorrect Relative Path for Including lvgl.h in lv_rnd_unicodes.h #6117

1saeed opened this issue Apr 23, 2024 · 2 comments · Fixed by #6141
Labels
stale

Comments

@1saeed
Copy link

1saeed commented Apr 23, 2024

LVGL version

v9.1

What happened?

Environment:

Operating System: Linux
Library Version: V9.1

Description:
The file lv_rnd_unicodes.h incorrectly uses a relative path to include the lvgl.h header file. The current include statement #include "../lvgl.h" fails because lvgl.h is not located in the specified path. This could lead to compilation errors when the header is included in projects.

How to reproduce?

Steps to Reproduce:

Set up a project including the LVGL library.
Attempt to include lv_rnd_unicodes.h in any source file.
Compile the project.
Observe the compilation error related to the missing lvgl.h file.
Proposed Fix:
Change the include statement from:

#include "../lvgl.h"
to an absolute path based on the typical project structure:

#include "lvgl/lvgl.h"
Impact:
This change would prevent compilation errors and improve the usability of the library in diverse project setups.
kisvegabor added a commit to kisvegabor/lvgl_upstream that referenced this issue Apr 28, 2024
@kisvegabor
ci(test): fix include path
bb5699f 
fixes lvgl#6117
@kisvegabor kisvegabor mentioned this issue Apr 28, 2024
Merged
@kisvegabor
Copy link
Member

Hi,

Thank you for reporting it! I've fixed it here: #6141

#if LV_BUILD_TEST was also missing and that was why this file interacted with normal builds.

@lvgl-bot
Copy link

We need some feedback on this issue.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

@lvgl-bot lvgl-bot added the stale label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(test): fix include path kisvegabor/lvgl_upstream
3 participants
@kisvegabor @1saeed @lvgl-bot