Lume serve: expected to respect ServerOptions for location

[Level8Broccoli]

Version

2.1.4

Platform

Linux

What steps will reproduce the bug?

• Setup the config with a custom port (e.g. lume({server: {port: 1234}}))
• Using the url() from Lume.Helpers with absolute set to true
• Run deno task lume --serve

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

I am happy to be corrected if I misunderstand something, but I would have expected the output of Lume.Helpers.url("/test", true) to be http://localhost:1234/test (with the custom port 1234 defined in the config).

What do you see instead?

It outputs http://localhost:3000/test, presumably because of the logic inside lume/core/utils/cli_options.ts:getOptionsFromCli(), where it falls back onto port 3000 when there is nothing passed by CLI.

Additional information

I am new to Deno and Lume and am really liking it. Great job. (This is my first issue I open on a FOSS project on github, so please let me know if I can improve the issue).

[oscarotero]

Hi. Yes, this is a bug, sorry for the troube.
I can't believe I didn't catch this before, thanks for letting me know!
It will be fixed in the next release of Lume. Meanwhile, you can use the --port argument: deno task lume --serve --port=1234

[oscarotero]

Fixed in Lume 2.2.0.