Mismatch results in dev with the flag --location

[metacriacoes]

The code:

// _config.ts

import lume from "https://deno.land/x/[email protected]/mod.ts";

const site = lume({
  location: new URL("http://localhost:8888"),
  server: {
    port: 8888
  }
});

console.log(`site.options.location.href: ${site.options.location.href}`);

export default site;

Command A:

deno run --unstable -A https://deno.land/x/[email protected]/cli.ts -s -d

Output A:

...
site.options.location.href: http://localhost:3000/
...

Command B:

deno run --unstable -A https://deno.land/x/[email protected]/cli.ts -s -d --location=http://localhost:8888

Output B:

...
site.options.location.href: http://localhost:8888/
...

---

Shouldn't the --location flag be just an override of the location option? Why the different results?

Thanks.

[oscarotero]

If an explicit --location is passed to the CLI, it's supposed that you want to override the default localhost domain. For example, to use a different hostname (like hostname.local).

[metacriacoes]

Yes. And if the location option is set in the _config.ts file, like in the example. Shouldn't the output be the same?

[oscarotero]

In this case, the hostname is localhost.
You can see the implementation here: https://github.com/lumeland/lume/blob/master/mod.ts#L82-L86
(options.location is the value of --location) and options.serve is true if the flag -s or --serve is set.

[metacriacoes]

Oh, got it. With -s the location is always overrided. Thanks.

Great work! I'm enjoying Lume very much.