Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to include custom swagger extensions in config #1533

Closed
wants to merge 1 commit into from
Closed

add ability to include custom swagger extensions in config #1533

wants to merge 1 commit into from

Conversation

gwprice115
Copy link

All Submissions:

More than happy to write tests and stuff once I get confirmation this is the right approach

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
closes #1532
Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

@gwprice115 gwprice115 mentioned this pull request Jan 8, 2024
Open
4 tasks
github-actions[bot]
github-actions bot reviewed Jan 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there gwprice115 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@TristanSpeakEasy
Copy link

Would love to see this go in will make our lives much easier

@WoH
Copy link
Collaborator

WoH commented Feb 8, 2024

This would probably require us to also be able to use a .tsoa.js as config file instead of the tsoa.json, if you don't call generateSwagger directly, but use the cli. (And also live in the spec config)
Also, it should be bw-compat if not provided.

@gwprice115
Copy link
Author

This would probably require us to also be able to use a .tsoa.js as config file instead of the tsoa.json, if you don't call generateSwagger directly, but use the cli. (And also live in the spec config) Also, it should be bw-compat if not provided.

gotcha makes sense--would you accept it if it was a static reference similar to how auth is specified?

@WoH
Copy link
Collaborator

WoH commented Feb 29, 2024

Yes

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Mar 31, 2024
@github-actions github-actions bot closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability for custom annotations to write Extensions
3 participants
@gwprice115 @TristanSpeakEasy @WoH