Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual input shows when multiple available not added at all #35

Closed
ksmrekar opened this issue Oct 7, 2023 · 2 comments · Fixed by #54
Closed

Manual input shows when multiple available not added at all #35

ksmrekar opened this issue Oct 7, 2023 · 2 comments · Fixed by #54

Comments

@ksmrekar
Copy link

ksmrekar commented Oct 7, 2023

I noticed this issue where the script seems to be lagging since it's not outputting anything. After a while it started to log again but it jumped quite in the percentage so I assumed something went wrong. Checked my TV Time csv and looked on the rows where it "lagged" and it turns out it was always on the shows I had to manually input which one to import.

I dug a bit in the code and it seems there is an error in searcher.py line 204. It checks if skip_show is None instead of False. I'm not sure if this is because of my python version (I'm using 3.9.5) and if in newer version False is considered None (I know C++ does this, but don't recall python having it like this). skip_show is False for those shows so I'm presumming this is a coding error. I changed it on my side and now all my show synced with no problem.

Thanks for making this script you've saved me!

@mindtakerr
Copy link

mindtakerr commented Jan 1, 2024

Thank you for posting about this, @ksmrekar! I had the same bug and your fix worked for me as well!

Although... now I see that it actually adds the wrong one, which based on other issues, appears to be a problem of the Trakt module. Maybe the check was set to None so that it doesn't accidentally tag the wrong data.

@seaque
Copy link

seaque commented Jan 11, 2024

Thank you for posting about this, @ksmrekar! I had the same bug and your fix worked for me as well!

Although... now I see that it actually adds the wrong one, which based on other issues, appears to be a problem of the Trakt module. Maybe the check was set to None so that it doesn't accidentally tag the wrong data.

That's the most severe issue during sync, you select the right option but Trakt gets the wrong one. #15

Result! With moving over to pytrakt, we can finally get the correct show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants