-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onSelectItems fn calls on dragging the item for reorders every time. #251
Comments
any help here @lukasbach ? highly appreciated!! |
Hi @Nishchit14, can you try to use the |
Thank you for the reply, Can you please share a doc or example that is available in the codebase? I've searched it but couldn't find anything other than props |
There are no good docs on the exact logic right now, but the intent is that it calls when the user clicks on an item with probably no tree-navigation related intent. The exact logic you can see in the implementation, and is pretty much
You can test when it is triggered in this example. If you want to further customize which kind of user interaction triggers what, you can use custom interaction modes |
Describe the bug
When I start dragging the item to re-arrange the order, it always calls the
onSelectItems
function. On theonSelectItems
call I am opening a file in a new tab (similar to vs code experience), due to this side effect the UX experience seems to be poor as the user is not intended to open the file while dragging it for re-order.To Reproduce
onSelectItems
funExpected behavior
On dragging the item the onSelectItems fn should not be called
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: