Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reason for combining rotary and relative positional embedding? #12

Open
oxjohanndiep opened this issue Jul 2, 2022 · 1 comment
Open

Reason for combining rotary and relative positional embedding? #12

oxjohanndiep opened this issue Jul 2, 2022 · 1 comment

Comments

@oxjohanndiep
Copy link

Hi,

Awesome work first of all.
Is there a reason why you would combine both rotational as well as relative positional embedding in your Attention class?
I would assume one of both is enough to incorporate the positions of the frames to the attention model?
@HiSultryMan
Copy link

same doubt here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HiSultryMan @oxjohanndiep