Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifier free guidance for prior model #285

Open
macrohuang1993 opened this issue Apr 6, 2023 · 1 comment
Open

Classifier free guidance for prior model #285

macrohuang1993 opened this issue Apr 6, 2023 · 1 comment

Comments

@macrohuang1993
Copy link

macrohuang1993 commented Apr 6, 2023

Hello everyone,
For the "DiffusionPriorNetwork" "forward_with_cond_scale" method:
null_logits = self.forward(*args, text_cond_drop_prob = 1., image_cond_drop_prob = 1, **kwargs)

Could someone explain why we also drop the image_embed via image_cond_drop_prob? I think "image_embed" should be kept even in the unconditional generation since that is the noisy CLIP image embedding, and the classifier free guidance should only drop the text_condition part for calculating null_logits.

Thanks!

@tengteng95
Copy link

@macrohuang1993 Hello, have you found the reason? I have the same question. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants