@zaguiini Thank you for submitting this PR!

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 44919,
  "author": "zaguiini",
  "owners": [
    "mike-engel",
    "aecorredor"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "066925e",
  "headCommitOid": "066925ef973168bae5e11553579d206522e80479",
  "mergeIsRequested": false,
  "stalenessInDays": 1,
  "lastCommitDate": "2020-05-20T13:24:49.000Z",
  "lastCommentDate": "2020-05-20T13:19:58.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44919/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "graphql-resolvers"
  ],
  "files": [
    {
      "filePath": "types/graphql-resolvers/index.d.ts",
      "kind": "definition",
      "package": "graphql-resolvers"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-21T18:19:49.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

🔔 @mike-engel @aecorredor - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

graphql-resolvers (unpkg)

was missing the following properties:

1. all
2. pipe
3. combine

Generated by 🚫 dangerJS against 066925e

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Updated numbers for you here from 26681b4.

It looks like there are several metrics that changed quite a bit. You might want to take a look and make sure your changes won’t cause slow-downs for users consuming these types.

I just published @types/[email protected] to npm.