Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression at 2.2.0? #172

Open
jmealo opened this issue Dec 30, 2023 · 0 comments
Open

Possible regression at 2.2.0? #172

jmealo opened this issue Dec 30, 2023 · 0 comments

Comments

@jmealo
Copy link

jmealo commented Dec 30, 2023

Hello,

Thanks for the excellent library. I make use of it in background-action (a GitHub action designed to block a step until a condition is met, using the wait-on library). It buffers stdout and stderr to files so the output can be tailed in GitHub actions, and optionally, output during the post-run step.

To eliminate duplicate output, it supports outputting only lines that weren't tailed (the resume option).

The test for resuming output begins failing with [email protected]:
https://github.com/JarvusInnovations/background-action/blob/9b4ab5bdc483d7f21f3d1c7da10144d5b327b264/test/success.test.js#L74

I've compared the versions and only see the addition of the nLines option. I haven't been able to track down the issue and will be locking in at 2.1.1 for now.

I'm posting this here in case anyone else encounters issues upgrading (or if you might have any ideas regarding the change in behavior?).

Thanks,
Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant