Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename logic is incorrect on Linux #131

Open
lucagrulla opened this issue Apr 9, 2021 · 1 comment
Open

rename logic is incorrect on Linux #131

lucagrulla opened this issue Apr 9, 2021 · 1 comment

Comments

@lucagrulla
Copy link
Owner

the rename logic didn't work without swapping:

if (filename === undefined || filename !== this.filename) {

to

if (filename === undefined || filename === this.filename) {

this was on Linux,[...] It would seem on Linux that the rename argument is the "from" filename, I guess?[...]

Originally posted by @bruce-one in #130 (comment)

@joac
Copy link

joac commented Jun 3, 2024

Had this issue, I think the approach from https://github.com/logdna/tail-file-node to handle renames is a lot more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants