Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres support #959

Open
1 task done
tomlawesome opened this issue Nov 25, 2021 · 33 comments · May be fixed by #3748
Open
1 task done

Postgres support #959

tomlawesome opened this issue Nov 25, 2021 · 33 comments · May be fixed by #3748
Labels
area:core issues describing changes to the core of uptime kuma feature-request Request for new features to be added

Comments

@tomlawesome
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

Allow users to use an external Postgres database to store all configuration/info for Uptime Kuma

✔️ Solution

Add support for Postgred databases

❓ Alternatives

Add support for MySQL though personally, I think Postgres is better.

📝 Additional Context

I think currently, data is store with sqlite? I would rather store my data on my existing database server because I have backup routines, etc, which will protect the data. I like to keep the dat a spearate from the app so I can just reinstall the app, point it at the correct database

@tomlawesome tomlawesome added the feature-request Request for new features to be added label Nov 25, 2021
@deefdragon

This comment was marked as outdated.

@trogper
Copy link
Contributor

trogper commented Dec 18, 2021

I have made branch with mysql support in my fork. See my comment in #953.
Adding postgres support should be just a few lines of code in knexfile.js. Please read the comment and try it out if you can

@ondrejsika

This comment was marked as spam.

@trogper
Copy link
Contributor

trogper commented Dec 29, 2021

Postgres should be possible in my fork, you can try it out. Just edit knexfile.js

@gc-ss
Copy link

gc-ss commented Apr 1, 2022

Postgres should be possible in my fork, you can try it out. Just edit knexfile.js

There are people who would love to use uptime-kuma if it had Postgres support. It's great to hear your fork supports Postgres - can you/someone explain to me why your fork can't be merged back into this uptime-kuma repo?

@trogper
Copy link
Contributor

trogper commented Apr 3, 2022

@gc-ss It's still work in progress, or more of a proof of concept. There are a few things to be decided upon and I dont think I am the one who should do it.
Read my comment, where I explaned it a bit or my PR #1139

@gc-ss
Copy link

gc-ss commented Apr 3, 2022

I dont think I am the one who should do it.

The usecase here is to allow multiple sources to write/update uptime-kuma concurrently.

I imagine the reason why a lot of interest in Postgres exists is to allow concurrent writes and people are ready to employ Postgres instead of trying to scale SQLite.

Is that why you too added Postgres support?

I believe there's a way where we can just continue to use the current SQLite integration and also allow concurrent writes. Here's how:

There is a copy of SQLite that has fantastic concurrent write support.

This is a great article by itself but feel free to jump to the last paragraph

https://blog.expensify.com/2018/01/08/scaling-sqlite-to-4m-qps-on-a-single-server/amp/

  1. If I can chase this copy of SQLite with concurrent write support down
  2. Will you be able to help test it with me and ensure it works with uptime Kuma without breaking existing uptime Kuma functionality?

Again - Thank You for your contributions and time!

@trogper
Copy link
Contributor

trogper commented Apr 3, 2022

If by concurrent writes you mean running multiple instances of kuma on a single database, then I think that will break a lot of things in kuma.
I added primarily MySQL support because I wanted to deploy kuma to Google Cloud Run (docker on google cloud), which does not support writing to local files. Additionally I prefer having data stored in a traditional database, as having it in a SQLite file insde a continer seems like a black box to me. I have not finished/worked on it as I am busy with school and work currently.

I am afraid kuma will not opt to use this copy (fork) of SQLite by default, as it seems to solve only one peculiar requirment, which might collide with another requirment of another user. I personally am wary of using smaller forks of software, as many times they lack support and maintenance of the original.

Why do you need concurrent writes to kuma database? What is your "business case"?

@AtjonTV
Copy link

AtjonTV commented Sep 1, 2022

Yesterday I started to consolidate my PostgreSQL Servers into a hosted Database Service to remove the burden of managing multiple server instances.
I wanted to include the Kuma database too so that I have all data and backups in one place, but sadly Kuma currently only supports SQLite.

@Maffsie
Copy link

Maffsie commented Sep 14, 2022

Any hope of this, or MySQL, being merged in any time soon? I'm running Uptime Kuma locally with a database size of approx. 700MB (around 50 separate checks so far), and I'm finding the performance worsens over time at about the same rate I experienced with Grafana before I moved that service to using a separate database. I'd really like to move Uptime Kuma to using my Postgres or MySQL/MariaDB servers, for better interactive performance.

@Freezepop

This comment was marked as spam.

@Maven35

This comment was marked as off-topic.

@trogper

This comment was marked as resolved.

@Maven35
Copy link

Maven35 commented Jan 29, 2023

@trogper you are correct, but getting off of SQLite is at least a step toward that. I'm aware that there would have to be other serious architectural changes to the application to support multiple instances of the application running concurrently.

@Milo123459

This comment was marked as resolved.

@trogper
Copy link
Contributor

trogper commented Mar 4, 2023

Edit (@CommanderStorm): Updated this comment to reflect the current release planning

@Milo123459 if you mean Postgres support, people have already done it, but it is not merged.
While mariaDB-support is included in the 2.0 release, Postgres-support was pushed off for another major release due to the reasons listed here #3748 (comment)

You can subscribe to #3748 or to this issue to get notified once this is the case

@Milo123459

This comment was marked as resolved.

@trogper

This comment was marked as resolved.

@Milo123459

This comment was marked as resolved.

@cypa

This comment was marked as resolved.

@harryzcy harryzcy linked a pull request Sep 15, 2023 that will close this issue
7 tasks
@lucyrose39

This comment was marked as off-topic.

@CommanderStorm CommanderStorm mentioned this issue Nov 10, 2023
1 task
@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Dec 8, 2023
@brooksvb

This comment was marked as duplicate.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 17, 2024

Not really a database issue, more a "how do we use the db"- issue.
v2 will be able to support way more monitors even using SQLite aggregated storage and other improvements like #3515
Benchmarking of the newer limit is currently outstanding, as waiting for a few bugfixes.
See #4500 for further context.

If you are running into problems with 160 monitors, something fishy is going on. Normally, users report problems after 500-800 monitors.

@brooksvb

This comment was marked as resolved.

@fabry006

This comment was marked as spam.

@CommanderStorm

This comment was marked as resolved.

@lucyrose39

This comment was marked as off-topic.

@CommanderStorm

This comment was marked as resolved.

@Aj7Ay

This comment was marked as resolved.

@CommanderStorm

This comment was marked as resolved.

@Aj7Ay

This comment has been minimized.

@CommanderStorm

This comment has been minimized.

@Aj7Ay

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma feature-request Request for new features to be added
Projects
None yet