Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show API Keys disabled msg. when disabled Auth #4723

Merged
merged 4 commits into from Apr 30, 2024

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #4628

Show API Keys disabled message when Auth is disabled.

Small formatting change to existing code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏻
Could you rebase this on 1.23.X?

@CommanderStorm CommanderStorm added the area:documentation Improvements or additions to documentation label Apr 28, 2024
@CommanderStorm CommanderStorm added this to the 1.23.14 milestone Apr 28, 2024
@chakflying chakflying changed the base branch from master to 1.23.X April 30, 2024 19:55
@CommanderStorm CommanderStorm merged commit 59f10d5 into louislam:1.23.X Apr 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling user auth also disables the API token requirement for /metrics
2 participants