Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] API key as docker secret #740

Open
lonix1 opened this issue Jul 12, 2022 · 0 comments
Open

[Feature Request] API key as docker secret #740

lonix1 opened this issue Jul 12, 2022 · 0 comments

Comments

@lonix1
Copy link

lonix1 commented Jul 12, 2022

Currently the API key is provided in an env file. That means it is exposed as an environment variable, as well as in logs.

Ideally it should be a docker secret.

On the host it would (still be) the responsibility of the user how to handle it - it's not baget's problem. But in the container, it would be mounted as a file and so cannot leak.

If the user is not using a docker swarm then docker secrets are not available, so in that case just let him use environment variables as usual (or he should run a single-node swarm, which is easy to do). That would be backwards compatible.

Thank you for considering it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant