Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minor mistake in Chapter 5 #78

Open
richardmyu opened this issue Apr 28, 2018 · 3 comments
Open

A minor mistake in Chapter 5 #78

richardmyu opened this issue Apr 28, 2018 · 3 comments
Labels

Comments

@richardmyu
Copy link

richardmyu commented Apr 28, 2018

Thanks for the excellent book!
I found a minor mistake in chapter05/03-DoublyLinkedList2.js :

insert(){
if () {
if () {
...
} else if (position === this.size()) {
//error
current = tail;
//ok
current = this.getTail();
} else {
...
}
}
}

@loiane
Copy link
Owner

loiane commented May 1, 2018

Thanks @richardmyu - this has been fixed in the newest edition of the book. Source code is available at the master branch

@loiane loiane added the Errata label May 1, 2018
@easyandme
Copy link

@loiane Hi Loiane. Thank you for this great book!

it seems that in the current Graph implementation, one can add duplicate edges to the adjacency list - is this expected? Thank you!

@loiane
Copy link
Owner

loiane commented Jun 26, 2018

@maxim-xu You are correct, let me review the code to prevent this behavior. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants