Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility #8

Closed
logrusorgru opened this issue Apr 17, 2019 · 7 comments
Closed

Backward compatibility #8

logrusorgru opened this issue Apr 17, 2019 · 7 comments
Assignees
Labels

Comments

@logrusorgru
Copy link
Owner

The v1.1 should be backward compatible with previous Aurora implementation. Please, let me know if the v1.1 breaks something.

@logrusorgru logrusorgru self-assigned this Apr 17, 2019
@logrusorgru logrusorgru pinned this issue Apr 17, 2019
@WGH-
Copy link

WGH- commented Apr 23, 2019

cannot use aurora.NewAurora(false).Gray (type func(uint8, interface {}) aurora.Value) as type func(interface {}) aurora.Value in assignment

@logrusorgru
Copy link
Owner Author

Hello, @WGH- , I've renamed v1.1 to v2.0. For now v1.0 is old (initial) version of the Aurora. Please, use

"gopkg.in/logrusorgru/aurora.v1"

import path.

GoDoc documentation.

@ryanavella
Copy link

Hi @logrusorgru, regarding @WGH-'s example, do you plan to document changes to the API? For example, BgGray now requires 2 arguments instead of 1.

@logrusorgru
Copy link
Owner Author

Hello, @ryanavella, please take a look at this paragraph: Grayscale. A Gray and a BgGray method require gray color index (from 0 to 23 inclusive) and value to make it gray. There is GoDoc documentations. Zero is black, 23 is white.

If a Gray or BgGray receive gray color out of the [0; 23] range, then nearest valid value used instead.

The Gray and BgGray methods are the same as Index and BgIndex where [0; 23] becomes [232; 255]. It's just 8-bit ANSI colors.

Also, there is CHANGELOG.md


Previous Gray and BgGray methods are now called White and BgWhite following specification. Also, Brown and BgBrown is now Yellow and BgYellow. There are Brown and BgBrown but they are marked as deprecated.

@logrusorgru
Copy link
Owner Author

logrusorgru commented Feb 8, 2020

If a Gray or BgGray receive gray color out of the [0; 23] range, then nearest valid value used instead.

Going to change it and introduce GrayScale and BgGrayScale. To make method names a bit intuitive.

Ref.: #15

P.S.: rejected, nothing will be changed

@logrusorgru
Copy link
Owner Author

Seems, we need the gorename tool working with go modules, to make the changes.

@logrusorgru
Copy link
Owner Author

License has changed from the WTFPL to the Unlicense due to pkg.go.dev restriction. I hope no one is against it.

@logrusorgru logrusorgru unpinned this issue Nov 27, 2020
@logrusorgru logrusorgru pinned this issue Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants