Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused dependencies (fixes issue #4873) #4874

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thinrope
Copy link
Contributor

@thinrope thinrope commented Apr 10, 2024

One line description of pull request

Removing unused dependencies (fixes issue #4873)

Description:

While working on packaging latest plaso for Gentoo, I found three python modules (idna, cryptography, cffi) which are not referenced in any code, yet they are installed by some of the scripts.
Related issue: fixes #4873

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

log2timeline/plaso/log2timeline#4873 WIP

Bug: log2timeline#4873
Reported-by: Kalin KOZHUHAROV <[email protected]>
Signed-off-by: Kalin KOZHUHAROV <[email protected]>
log2timeline/plaso/log2timeline#4873 WIP

Bug: log2timeline#4873
Reported-by: Kalin KOZHUHAROV <[email protected]>
Signed-off-by: Kalin KOZHUHAROV <[email protected]>
log2timeline/plaso/log2timeline#4873 WIP

Bug: log2timeline#4873
Reported-by: Kalin KOZHUHAROV <[email protected]>
Signed-off-by: Kalin KOZHUHAROV <[email protected]>
It looks like it is relying on a hard-coded output that just happens to
have those module names?
log2timeline/plaso/log2timeline#4873 WIP

Bug: log2timeline#4873
Reported-by: Kalin KOZHUHAROV <[email protected]>
Signed-off-by: Kalin KOZHUHAROV <[email protected]>
@joachimmetz joachimmetz self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove indirect dependencies
2 participants