Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stagger key rotation when unwinding invalidated invitation #39

Open
Tracked by #33
HerbCaudill opened this issue Jan 27, 2022 · 0 comments
Open
Tracked by #33

Stagger key rotation when unwinding invalidated invitation #39

HerbCaudill opened this issue Jan 27, 2022 · 0 comments

Comments

@HerbCaudill
Copy link
Member

HerbCaudill commented Jan 27, 2022

Multiple admins could simultaneously see that there are pending key rotations. It might make sense to add a random delay before rotating keys, or to come up with another way to ensure that these don't pile up.

This happens in Team.checkForPendingKeyRotations

Test plan:

  • Builds on the test "unwinds an invalidated admission" in sync.test.ts
  • Instead of just Alice, there are multiple admins
  • Assert that the team keys are only rotated once
@HerbCaudill HerbCaudill changed the title If we have multiple admins, we don't want them to all jump on it at once because the duplicate actions will create a lot of churn. So maybe depending on how many admins there are in the group, we should wait some random amount of time before doing the key rotation. Stagger key rotation when unwinding invalidated invitation Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant