-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stagger key rotation when unwinding invalidated invitation #39
Comments
This was referenced Jan 27, 2022
HerbCaudill
changed the title
If we have multiple admins, we don't want them to all jump on it at once because the duplicate actions will create a lot of churn. So maybe depending on how many admins there are in the group, we should wait some random amount of time before doing the key rotation.
Stagger key rotation when unwinding invalidated invitation
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Multiple admins could simultaneously see that there are pending key rotations. It might make sense to add a random delay before rotating keys, or to come up with another way to ensure that these don't pile up.
This happens in Team.checkForPendingKeyRotations
Test plan:
sync.test.ts
The text was updated successfully, but these errors were encountered: