You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of people forget to fill the templates and send PRs for review without the proper information. Unfortunately, having the template means the check for description will always pass.
Exceptions:
We shouldn't try to apply it over all templates, but at least the one in Alice.
The text was updated successfully, but these errors were encountered:
Proposal:
Modify the check for description at https://github.com/loadsmart/peril-settings/blob/master/rules/common/needsDescription.ts to consider our pre-made PR description templates as if it was empty.
Reasoning
A lot of people forget to fill the templates and send PRs for review without the proper information. Unfortunately, having the template means the check for description will always pass.
Exceptions:
We shouldn't try to apply it over all templates, but at least the one in Alice.
The text was updated successfully, but these errors were encountered: