Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Needs Description" check should ignore decription templates #76

Open
gbenatt92 opened this issue Dec 27, 2019 · 0 comments
Open

"Needs Description" check should ignore decription templates #76

gbenatt92 opened this issue Dec 27, 2019 · 0 comments

Comments

@gbenatt92
Copy link

Proposal:

Modify the check for description at https://github.com/loadsmart/peril-settings/blob/master/rules/common/needsDescription.ts to consider our pre-made PR description templates as if it was empty.

Reasoning

A lot of people forget to fill the templates and send PRs for review without the proper information. Unfortunately, having the template means the check for description will always pass.

Exceptions:

We shouldn't try to apply it over all templates, but at least the one in Alice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant