Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge on green not working for required review #42

Open
eduardocardoso opened this issue Jun 21, 2018 · 1 comment
Open

Merge on green not working for required review #42

eduardocardoso opened this issue Jun 21, 2018 · 1 comment

Comments

@eduardocardoso
Copy link
Contributor

Proposal:

Run merge-on-green.ts when a PR review is added

Reasoning

If an approving review is added after all the status checks are already green the PR is not merged automatically. merge-on-green is set to run only on status.success event but, apparently, an approving review does not generate a status.success event.
@eduardocardoso eduardocardoso mentioned this issue Jun 21, 2018
Merged
@camilamaia camilamaia reopened this Jul 5, 2018
@camilamaia
Copy link
Contributor

@eduardocardoso this is still not working, is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@camilamaia @eduardocardoso