/editor commands on Windows leave stray temp files
#224
Labels
bug
Something isn't working
Comments
|
This may offer some clues to a solution: https://stackoverflow.com/questions/7713077/python-subprocess-kill-doesnt-release-the-file-handle |
thehunmonkgroup
added a commit
that referenced
this issue
Mar 12, 2023
Prints an ugly warning on Windows systems, better than failing for now
|
8ee2cfd allows the editor command to work on Windows, at the expense of not cleaning up any of the temp files created to make it operate :( I spent quite some time trying to solve the issue, as far as I can tell, there is no other process holding file file open. If anyone else can figure this out, please let me know. For now, I print an ugly and annoying message on Windows when the pipe editor is used, informing the user that they'll have to clean up temp files by hand if they want. |
thehunmonkgroup
changed the title
/editor commands seem to be broken on Windows/editor commands on Windows leave stray temp files
itsnotgunnar
added a commit
to itsnotgunnar/chatgpt-wrapper
that referenced
this issue
Jun 6, 2023
* **Mon Jun 05 2023:** add template/variable support for workflows * **Mon Jun 05 2023:** tweak lwe ansible module exit data * **Mon Jun 05 2023:** move template manager instantiation to backend * **Mon Jun 05 2023:** document running workflows directly with ansible-playbook * **Mon Jun 05 2023:** add default ansible callback config * **Mon Jun 05 2023:** fix missing workflow directories * **Sun Jun 04 2023:** fixes to workflow CLI help * **Sun Jun 04 2023:** add documentation for workflows * **Sun Jun 04 2023:** flesh out lwe doc * **Sun Jun 04 2023:** migrate workflow from plugin to API backend * **Sun Jun 04 2023:** add workflow show/edit/delete commands * **Sun Jun 04 2023:** output YAML in workflow runs * **Sun Jun 04 2023:** allow both user IDs and usernames in user arg to lwe module * **Sun Jun 04 2023:** refine and comment example workflows * **Sun Jun 04 2023:** save conversation ID in lwe results dict * **Sun Jun 04 2023:** convert lwe ansible module to LWE API backend * **Sun Jun 04 2023:** add backend_options.default_user, backend_options.default_conversation_id to config, backend loading of default user/conversation * **Sat Jun 03 2023:** provide default file for extravars * **Sat Jun 03 2023:** support passing workflow args in /workflow-run * **Sat Jun 03 2023:** include more example workflows, mechanism for collecting var_prompt variables in playbooks * **Sat Jun 03 2023:** initial ansible playbook integration for workflows * **Sun May 28 2023:** bold styling for user prompt * **Sun May 28 2023:** color-code role labels in /chat output * **Mon May 22 2023:** very basic workflow manager and workflow base class, with test workflow in Prefect * **Sat May 27 2023:** allow setting system message alias in config (model.default_system_message) or CLI (-s/--system-message) * **Sat May 27 2023:** read both extra params and input file for one-shot mode * **Thu May 25 2023:** add -i/--input-file argument * **Mon May 22 2023:** restore SQLAlchemy compat with 1.4.x * **Thu May 18 2023:** kill lingering deprecated chatgpt-browser/chatgpt-api * **Thu May 18 2023:** fix streaming when overriding a preset in templates * **Wed May 17 2023:** add doc for browser backend with web browser support * **Wed May 17 2023:** add support for ChatGPT with browsing (alpha, browser backend only) * **Mon May 15 2023:** fix broken streaming, clean up can/should stream logic, fixes llm-workflow-engine#303 * **Mon May 15 2023:** clean up alembic config process * **Mon May 15 2023:** add util function to get directory of any file * **Mon May 15 2023:** fix missing alembic files * **Sun May 14 2023:** fix missing __init__ file for schema dir * Configuration `backend:` settings have changed values * `chatgpt-api` is now `api` * `chatgpt-browser` is now `browser` * **Sat May 13 2023:** fix some message composition and streaming bugs * **Sat May 13 2023:** fix default args to prevent mutable default args bugs * **Sat May 13 2023:** update backend config names, add deprecation warning for old names This version performs operations on the database that stores users/conversations/messages. **Please read the the upgrade warnings at https://github.com/mmabrouk/chatgpt-wrapper#upgrading prior to running the upgrade!** * Plugin support for browser backend * Database schema upgrade system * Per user default presets * Switching conversations loads original preset or provider/module used when conversation was created * **Sat May 13 2023:** document per-user default presets * **Sat May 13 2023:** fix random bugs with streaming across providers * **Sat May 13 2023:** document plugin support * **Sat May 13 2023:** /plugin-enable and /plugin-disable commands, dynamically add/remove plugins * **Sat May 13 2023:** add /enabled-plugins command * **Sat May 13 2023:** underscore commands in help command substitution * **Sat May 13 2023:** add plugin support to browser backend, /plugins list command * **Sat May 13 2023:** add database upgrade warnings to README * **Sat May 13 2023:** add prompt replacement token, indicator for active preset in /presets command * **Sat May 13 2023:** schema upgrade, store provider and preset for conversation, use when re-loading conversations * **Sat May 13 2023:** exit on upgrade error * **Sat May 13 2023:** improve stream logging * **Sat May 13 2023:** working user default presets * **Fri May 12 2023:** improve display/management of system message aliases * **Thu May 11 2023:** schema upgrade, default_model -> default_preset for users * **Thu May 11 2023:** database schema upgrade system using alembic * **Wed May 10 2023:** clarify doc for presets * **Tue May 09 2023:** timeout for trying to retrieve awesome prompts This is a substantial rewrite to add support for multiple providers and management of preset configurations. New features are documented in the README. * Removed the following values from `shell.prompt_prefix`: * `$TOP_P` * `$PRESENCE_PENALTY` * `$FREQUENCY_PENALTY` * Removed `chat.model` configuration setting. * Removed `chat.model_customizations` configuration setting. * Added a new `model` configuration hash, with the following new attributes: * `default_preset` * Moved `chat.model_customizations.system_message` configuration setting to `model.system_message` * Moved `chat.streaming` configuration setting to `model.streaming` * `--model` command line argument has been removed * `--preset` command line argument has been added * Saving/editing a default model per user in the API backend has been removed * `/model` command has been rewritten. See `/help model` for more information * Removed the following commands: * `/model-temperature`: Now set under `/model temperature` * `/model-top-p`: Now set under `/model model_kwargs` * `/model-presence-penalty`: Now set under `/model model_kwargs` * `/model-frequency-penalty`: Now set under `/model model_kwargs` * Renamed the following commands: * `/model-system-message` to `/system-message` * Special `model_customizations` variable has been renamed to `request_overrides`, and functionality has changed. See the `Templates` section in the README for more info. * API backend modules location changed to `backends/api` * API backend file location changed to `backends/api/backend.py` * API backend class `OpenAIAPI` renamed to `ApiBackend` * Removed the following abstract methods from the base `Backend` class: * `get_backend_name` * `set_available_models` * Added the following abstract methods to the base `Backend` class: * `set_override_llm` * **Mon May 08 2023:** update documentation for presets/providers * **Mon May 08 2023:** add /providers command to list providers, sort presets/templates * **Mon May 08 2023:** update example config * **Mon May 08 2023:** enhance browser backend test, add wait arg * **Mon May 08 2023:** convert all direct API calls in browser backend to use injected XHR requests * **Mon May 08 2023:** function/var renames for clarity * **Mon May 08 2023:** update pip package description * **Mon May 08 2023:** rename classes for clarity * **Sun May 07 2023:** add commented list of openai codex models * **Sun May 07 2023:** add huggingface_hub provider * **Sun May 07 2023:** add openai provider * **Sun May 07 2023:** add AI21 provider * **Sun May 07 2023:** update CLI args, remove model, add preset * **Sun May 07 2023:** fix streaming on override LLM * **Sun May 07 2023:** custom LLM override functionality, allow override using preset in templates * **Sun May 07 2023:** include name in preset metadata * **Sun May 07 2023:** re-add max-submission-tokens, abstract for multiple providers, enhance error message for get_set_backend_setting(), add get_capability() method to provider class, discover provider from model, use when switching conversations, remove errant streaming capabilitiy from cohere provider * **Sat May 06 2023:** update sample config * **Sat May 06 2023:** move preset_manager to backend, refactor init model to init with default preset, remove dead constants, model_customizations -> request_overrides, refactor config setting locations * **Sat May 06 2023:** strings instead of arrays for non-chat LLM messages * **Sat May 06 2023:** upgrade langchain/sqlalchemy, cohere dep * **Sat May 06 2023:** abstract title generation, message preparation/extraction * **Sat May 06 2023:** REPL stream references backend stream setting * **Fri May 05 2023:** should_stream() for backend, look at streaming setting directly * **Thu May 04 2023:** add get_customizations() method, scrubs metadata * **Thu May 04 2023:** working presets, fix streaming in API backend * **Wed May 03 2023:** add cohere plugin * **Wed May 03 2023:** rebuild completions on provider change, start abstracting model property name * **Wed May 03 2023:** /provider command to switch providers * **Wed May 03 2023:** more robust provider loading * **Wed May 03 2023:** add PROVIDER_PREFIX constant * **Wed May 03 2023:** display/full name management for providers * **Wed May 03 2023:** refactor model handling, get/set models * **Wed May 03 2023:** restrict langchain version, fixes llm-workflow-engine#296 * **Tue Apr 25 2023:** check for and close browser page in cleanup() * **Mon Apr 24 2023:** basic working API backend implementation with ChatOpenAI * **Sun Apr 23 2023:** clarify instructions for GPT-4 use * **Sat Apr 22 2023:** check for existing browser pages before closing context, add more debugging to cleanp() * **Thu Apr 13 2023:** rip out model specific commands, refactor do_model, fix model completions * **Thu Apr 13 2023:** loosen up timestamp string for conversion, fixes llm-workflow-engine#287 * **Wed Apr 12 2023:** move llm creation into provider class, move browser backend provider to plugin * **Wed Apr 12 2023:** initial preset manager * **Tue Apr 11 2023:** make api key/org private * **Tue Apr 11 2023:** PresetValue class, functionality to set model customizations * **Tue Apr 11 2023:** Get Docker container working, clarify documentation, fixes llm-workflow-engine#268, fixes llm-workflow-engine#276, fixes llm-workflow-engine#281 * **Tue Apr 11 2023:** clean up browser integration test * **Tue Apr 11 2023:** speed up zap plugin loading * **Mon Apr 10 2023:** move plugin manager instantiation to backends * **Mon Apr 10 2023:** support passing list of additional plugins to plugin manager * **Mon Apr 10 2023:** add provider base class, move chat_openai provider plugin * **Sat Apr 08 2023:** initial provider manager implementation * **Thu Apr 13 2023:** loosen up timestamp string for conversion, fixes llm-workflow-engine#287 * **Tue Apr 11 2023:** Get Docker container working, clarify documentation, fixes llm-workflow-engine#268, fixes llm-workflow-engine#276, fixes llm-workflow-engine#281 * **Tue Apr 11 2023:** clean up browser integration test * **Sat Apr 08 2023:** clarify API backed model is set per user, fixes llm-workflow-engine#283 * **Sat Apr 08 2023:** provide empty config if config file is empty, fixes llm-workflow-engine#282 * **Fri Apr 07 2023:** enable echo plugin by default, remove awesome plugin as default * **Fri Apr 07 2023:** move test plugin to echo * **Fri Apr 07 2023:** fix syntax error in setup script, fixes llm-workflow-engine#280 * **Fri Apr 07 2023:** add support for plugin packages * **Fri Apr 07 2023:** properly set user object in all login scenarios, fixes llm-workflow-engine#260, fixes llm-workflow-engine#262 * **Thu Apr 06 2023:** sync docs * **Wed Apr 05 2023:** enable console/file debugging for --debug arg, print backtrace on command exceptionn when --debug enabled * **Tue Apr 04 2023:** add shell.history_file config option * **Mon Apr 03 2023:** add support for listing incompatible backends in plugins * **Mon Apr 03 2023:** abstract prompt prefixing for REPLS, add model prefix for browser backend * **Mon Apr 03 2023:** add warning message for broken stream interruption on API backend * **Mon Apr 03 2023:** abstract launching browser context, add warning streaming not working properly on browser backend * **Sun Apr 02 2023:** support interrupting streaming on API backend * **Sun Apr 02 2023:** add current datatime util function * **Sun Apr 02 2023:** convert backends to use langchain custom chat LLM * **Sun Apr 02 2023:** move LLM class/object creation methods to base backend class * **Mon Apr 03 2023:** fix ctrl-c/ctrl-d functionality with prompt thread * **Sat Apr 01 2023:** reorg install section * **Sat Apr 01 2023:** update doc for backend installation * **Sat Apr 01 2023:** update sample config * **Sat Apr 01 2023:** register cleanup function for browser backend * All async functionality has been removed * Async functionality was determined to be overly complex and buggy for the common use cases in this project. * If you were using any async Python modules, switch to their sync version, and consider implementing your own async wrapper or using multithreading if necessary. * Browser backend and ChatGPT module usage have been deprecated * No support will be provided for ChatGPT module usage * API backend is now the default * Browser backend will remain for now, but may be removed in a future release * **Sat Apr 01 2023:** tweak config instructions * **Sat Apr 01 2023:** update docker entrypoint instructions * **Sat Apr 01 2023:** deprecate browser backend, ChatGPT module usage, default to API backend * **Sat Apr 01 2023:** make conversation_data_to_messages() consistent in browser backend * **Sat Apr 01 2023:** fix set_title(), cleanup get_history() on API backend * **Sat Apr 01 2023:** add helper func to convert SQLAlchemy objects to plain dicts * **Sat Apr 01 2023:** dynamically fetch history for older chats on switch/chat/title * **Fri Mar 31 2023:** completely rip out all async functionality * **Fri Mar 31 2023:** Add new_conversation to ChatGPT * **Thu Mar 30 2023:** add interactive arg to launch_backend(), fixes llm-workflow-engine#265 * **Thu Mar 30 2023:** add /copy command, fixes llm-workflow-engine#264 * **Wed Mar 29 2023:** fix broken template tests * **Wed Mar 29 2023:** add file/directory util functions * **Tue Mar 28 2023:** add LLM base methods for plugins to leverage * **Tue Mar 28 2023:** add support for .jsonl/.xml to data_query plugin * **Tue Mar 28 2023:** add config options to shell plugin * **Tue Mar 28 2023:** small logic improvements to database/data_query plugins * **Tue Mar 28 2023:** extend /config with edit/section args * **Mon Mar 27 2023:** add data_query plugin * **Mon Mar 27 2023:** more robust filename to class conversion * **Mon Mar 27 2023:** snake_to_class() util function * **Mon Mar 27 2023:** bump langchain required version * **Mon Mar 27 2023:** add database plugin * **Mon Mar 27 2023:** add agent:verbose config value to zap plugin * **Mon Mar 27 2023:** tighten up prompt template for generating shell commands * **Mon Mar 27 2023:** allow plugins/users to access configuration for plugins * **Mon Mar 27 2023:** return None on missing value in config.get() * **Sun Mar 26 2023:** add unit tests for util functions * **Sun Mar 26 2023:** reorg docs * **Sun Mar 26 2023:** convert to Pytest framework * **Sun Mar 26 2023:** fix SQLAlchemy deprecation warnings * **Sun Mar 26 2023:** per profile playwright sessions for browser backend * **Sun Mar 26 2023:** no password for test users * **Sun Mar 26 2023:** clean up errant `console` references, fixes llm-workflow-engine#256 * **Sun Mar 26 2023:** allow custom style for util.print_status_message() Lots of file/class/function reorganization: * Shell usage should be unaffected * Basic use cases of Python module should be unaffected * More complex use cases of Python module will probably need code adjustments * **Sat Mar 25 2023:** abstract template functionality, abstract common functions to util module * **Sat Mar 25 2023:** user found/not found message helper * **Sat Mar 25 2023:** reorg file structure, group modules into core/backends * **Fri Mar 24 2023:** add troubleshooting section to docs * **Fri Mar 24 2023:** add 'chatgpt reinstall' one shot command * **Thu Mar 23 2023:** add shell plugin * **Wed Mar 22 2023:** inject id into get_conversation() result, add timeout logic for api requests, use for gen_title() * **Tue Mar 21 2023:** add comment, ctrl-c interrupt generation not working on windows * **Tue Mar 21 2023:** add support for interrupting streaming by ctrl-c * **Mon Mar 20 2023:** fix issue writing awesome prompts CSV file * **Mon Mar 20 2023:** restore ability of /template-edit to create new templates * **Sun Mar 19 2023:** attempt to fix sync wrapper when loop is always running * **Sun Mar 19 2023:** add upgrading section to doc * **Sun Mar 19 2023:** add all core plugins to example config * **Sun Mar 19 2023:** add init file to plugins dir, fixes llm-workflow-engine#239 * **Sun Mar 19 2023:** add langchain dependency * **Sun Mar 19 2023:** add doc for current core plugins * **Sun Mar 19 2023:** add zap plugin * **Sat Mar 18 2023:** clean up template display/workflows * **Sat Mar 18 2023:** extract description separate from overrides, fixes llm-workflow-engine#238 * **Sat Mar 18 2023:** /templates command improvements * **Sat Mar 18 2023:** fix secondary invocations with browser backend, fixes llm-workflow-engine#236 The `--config-dir` and `--data-dir` arguments have changed how they interpret locations: * Both now point to the root `chatgpt-wrapper` directory instead of a profile directory * Config and data are still stored under `profiles/[profile]` subdirectories inside these directories * Installations that use the default locations instead of providing CLI arguments for the locations are unaffected * See the output of `chatgpt config` with no other arguments to see these updates reflected in the `File configuration` section * **Fri Mar 17 2023:** find version in version.py * **Fri Mar 17 2023:** doc for template front matter * **Fri Mar 17 2023:** refactor config/data dir implementation, support non-profile specific templates/plugins dirs **BREAKING CHANGE** * **Thu Mar 16 2023:** pretty up templates list output * **Thu Mar 16 2023:** add descriptions to example templates * **Thu Mar 16 2023:** better formatting of template front matter, use description key from front matter in /templates list * **Thu Mar 16 2023:** enable debug logging for test scripts * **Thu Mar 16 2023:** check for running event loop, use if found * **Thu Mar 16 2023:** clarify how to use the sample config * **Thu Mar 16 2023:** fix crash after initial user creation on api backend * **Wed Mar 15 2023:** Basic plugin functionality (alpha, subject to change) * **Wed Mar 15 2023:** improvements to model handling * **Tue Mar 14 2023:** set new backend model after user edit * **Tue Mar 14 2023:** add set_model method to API backend, error handling/logging for API requests * **Tue Mar 14 2023:** bump openai version requirement * **Tue Mar 14 2023:** Minor bug fix: model option was not used in the wrapper (default option was hardcoded) * **Tue Mar 14 2023:** added gpt4 model option * **Tue Mar 14 2023:** move signal handling to base shell class, fixes llm-workflow-engine#226 * **Tue Mar 14 2023:** repl_history file use platform agnostic temp dir, fixes llm-workflow-engine#227 * **Mon Mar 13 2023:** Convert commands from underscore to dash * **Mon Mar 13 2023:** don't start gen_title thread if title already exists * **Mon Mar 13 2023:** only add check_same_thread for sqlite connections * **Sun Feb 26 2023:** added flask to requirements * **Sun Feb 26 2023:** improvement to docker (speed up in debugging and adding api port) * **Mon Mar 13 2023:** fix threading error with SQLite connections * **Mon Mar 13 2023:** updates to example config * **Sun Mar 12 2023:** add note about adding EDITOR env var in Windows * **Sun Mar 12 2023:** try to get windows editor from env first * **Sun Mar 12 2023:** add install notes for windows users * **Sun Mar 12 2023:** launch backend after check for config CLI arg * **Sun Mar 12 2023:** fix ask/ask_stream signatures to support custom titles * **Sun Mar 12 2023:** add prompt-engineer example * **Sun Mar 12 2023:** add 'Backend configuration' section to config output * **Sun Mar 12 2023:** temp workaround for issue llm-workflow-engine#224 * **Sat Mar 11 2023:** allow overriding system message in template front matter * **Sat Mar 11 2023:** add support for frontmatter in templates * **Sat Mar 11 2023:** add some example templates and API scripts * **Sat Mar 11 2023:** allow passing custom title to ask/ask_stream in api backend * **Sat Mar 11 2023:** init defaults for templates * **Sat Mar 11 2023:** try to discover env editor on osx * **Sat Mar 11 2023:** template_copy/template_delete commands * **Sat Mar 11 2023:** kill special sauce for linux editor filetype, no longer needed * **Fri Mar 10 2023:** ensure self.templates is a list * **Fri Mar 10 2023:** add link to new video walkthrough * **Fri Mar 10 2023:** fix markdown filetype for vim syntax highlighting * **Fri Mar 10 2023:** **HOTFIX** for broken templates directory location * **Fri Mar 10 2023:** indicator for current conversation in /history list * **Fri Mar 10 2023:** tweak /chat help * **Fri Mar 10 2023:** set new conversation in API backend on user login * **Fri Mar 10 2023:** add default_user_id arg to init of API backend * **Fri Mar 10 2023:** add tests for chatgpt-api Python module * **Fri Mar 10 2023:** output user id in users list * **Fri Mar 10 2023:** add utility scripts for commit log and pypi release - Add completions for many more commands - Show/set system message (initial context message for all conversations) - System message aliases - Template management system. See below for details (alpha, subject to change) - Set 'markdown' filetype for editor invocations (supports syntax highlighting) - Add built template variables, see below for details - Native editor module (removes vipe dependency) - The return values for the public methods of the `ChatGPT`/`AsyncChatGPT` classes have changed, they are now tuple with the following values: - `success`: Boolean, True if the operation succeeded, False if the operation failed. - `data`: Object, the data the command generated. - `message`: Human-readable message about the outcome of the operation. - Introduced the concept of multiple 'backends' -- see below for the currently supported ones - Added the 'chatgpt-api' backend, communicates via the official OpenAI REST endpoint for ChatGPT - Basic multi-user support (admin party at CLI) - Data stored in a database (SQLite by default, any configurable in SQLAlchemy allowed) - Allows full model customiztion - Numerous new shell commands and enhancements - ChatGPT/AsyncChatGPT classes have changed how they receive configuration values, be sure to investigate the new function signatues for their __init__() and create() methods. - [New configuration system](/config.sample.yaml) - Added '/config' command - Fix broken `ChatGPT` sync class - Removed nest_asyncio dependency - Convert CLI to use `AsyncChatGPT` class - Initial implementation of stop generating text response - REVERT BREAKING CHANGE: Asyncio module requirement _removed_ from usage of ChatGPT class, it is now a sync wrapper around the async class - Command leader changed from '!' to '/' - Asyncio module is now required to use ChatGPT class directly (refer to [Python usage](#python)) - Added '/quit' command - Added '/delete' support for history IDs/UUIDs - Added '/chat' command - Added '/switch' command - Added '/title' command - Added limit/offset support for '/history' - **_Migrated to async Playwright_** - **_Initial API in Flask_** (see [How to use the API](#flask-api)) - Added tab completion for commands - Added '/tmp' volume for saving Playwright session - Added CI and CodeQL workflows - Added simple developer debug module - Improved session refreshing (**_/session now works!_**) - Migrated to Prompt Toolkit [See commit log for previous updates](#commit-log) - 21/02/2023: v0.3.17 - Added debug mode (visible browser window). - @thehunmonkgroup fixed chat naming. - @thehunmonkgroup added !delete command to remove/hide conversations. - @thehunmonkgroup added --model flag to select model ('default' or 'legacy-paid' or 'legacy-free'). - @thehunmonkgroup added !editor command to open the current prompt in an editor and send the edited prompt to ChatGPT. - @thehunmonkgroup added !history command to show the list of the last 20 conversations. - @NatLee added **docker** support. - 17/02/2023: v0.3.16 - Ability to open **multiple sessions in parallel**. - Code now works with **ChatGPT Plus** subscription. - 14/02/2023: v0.3.15 - Updated model to text-davinci-002-render-sha (turbo model). - 14/02/2023: v0.3.11 - Fixed many bugs with installation. Code is refactored. - Now able to use the python wrapper with a **proxy**. - 18/01/2023: v0.3.8 - Commands now are run only using !. For instance to enable read mode (for copy-paste and long prompts) you need to write now `!read` instead of `read`. This is to avoid conflicts with the chatgpt prompts. Fixed timeout issue. - 17/01/2023: v0.3.7 - Added timeout to `ask` method to prevent hanging. Fixed return to terminal breakdown. Streaming output now is activated by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows is making it very hard to do get the inline editing features working.
I get this error:
I'm not a Windows user, so I could use some help figuring out how to overcome this so the full featureset works in that environment.
So any Windows users out there, if you can help, please chime in...
The text was updated successfully, but these errors were encountered: