feature: automatically launch browser on bud run
#334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmueller
requested changes
Nov 29, 2022
internal/cli/run/run.go
Outdated
| if !c.Flag.Noautolaunch { // if not not autolaunch, i.e. if autolaunch | ||
| go func() { | ||
| time.Sleep(1 * time.Second) | ||
| _ = browser.OpenURL("http://" + webln.Addr().String()) |
There was a problem hiding this comment.
Should check the error
There was a problem hiding this comment.
this is the only guidance here i don't understand. why? i literally can't think of anything that we'd do differently if it fails or not. it's an optional convenience feature...
There was a problem hiding this comment.
My take is that if a user explicitly requested --open we should open or fail trying.
|
Thanks for the review and feedback- I will update the PR soon. |
sneak
added a commit
to sneak/bud
that referenced
this pull request
Nov 29, 2022
internal/cli/cli.go
Outdated
| @@ -63,6 +63,7 @@ func (c *CLI) Run(ctx context.Context, args ...string) error { | |||
| cli.Flag("embed", "embed assets").Bool(&cmd.Flag.Embed).Default(false) | |||
| cli.Flag("hot", "hot reloading").Bool(&cmd.Flag.Hot).Default(true) | |||
| cli.Flag("minify", "minify assets").Bool(&cmd.Flag.Minify).Default(false) | |||
| cli.Flag("open", "open browser on dev server startup").Bool(&cmd.Flag.OpenBrowser).Default(false) | |||
There was a problem hiding this comment.
Ah sorry, I might have missed this in the previous review but Flag is meant for global options that need to get passed into the framework. We should treat OpenBrowser like Listen below and stick it on the run command.
sneak
added a commit
to sneak/bud
that referenced
this pull request
Dec 3, 2022
sneak
force-pushed
the
sneak/open-browser
branch
from
abd4715
to
227541b
Compare
sneak
added a commit
to sneak/bud
that referenced
this pull request
Dec 3, 2022
sneak
force-pushed
the
sneak/open-browser
branch
from
227541b
to
31e089c
Compare
sneak
force-pushed
the
sneak/open-browser
branch
from
31e089c
to
3ce87a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #333